From 970e157eac73e6da41e1a3d11dbee0a39c067318 Mon Sep 17 00:00:00 2001 From: Benjamin Trent Date: Tue, 25 Jun 2019 10:09:39 -0500 Subject: [PATCH] [ML][Data Frame] Adjusting error message (#43455) (#43580) * Adjusting error message * Update TransportPutDataFrameTransformAction.java * Update TransportPutDataFrameTransformAction.java --- .../TransportPutDataFrameTransformAction.java | 21 ++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/action/TransportPutDataFrameTransformAction.java b/x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/action/TransportPutDataFrameTransformAction.java index 39b9a5fd18f..ef8a4f28d79 100644 --- a/x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/action/TransportPutDataFrameTransformAction.java +++ b/x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/action/TransportPutDataFrameTransformAction.java @@ -25,8 +25,6 @@ import org.elasticsearch.common.inject.Inject; import org.elasticsearch.common.io.stream.StreamInput; import org.elasticsearch.common.regex.Regex; import org.elasticsearch.common.settings.Settings; -import org.elasticsearch.common.xcontent.XContentBuilder; -import org.elasticsearch.common.xcontent.json.JsonXContent; import org.elasticsearch.license.LicenseUtils; import org.elasticsearch.license.XPackLicenseState; import org.elasticsearch.persistent.PersistentTasksCustomMetaData; @@ -233,17 +231,16 @@ public class TransportPutDataFrameTransformAction if (privilegesResponse.isCompleteMatch()) { putDataFrame(config, listener); } else { - XContentBuilder builder = JsonXContent.contentBuilder(); - builder.startObject(); - for (ResourcePrivileges index : privilegesResponse.getIndexPrivileges()) { - builder.field(index.getResource()); - builder.map(index.getPrivileges()); - } - builder.endObject(); + List indices = privilegesResponse.getIndexPrivileges() + .stream() + .map(ResourcePrivileges::getResource) + .collect(Collectors.toList()); - listener.onFailure(Exceptions.authorizationError("Cannot create data frame transform [{}]" + - " because user {} lacks permissions on the indices: {}", - config.getId(), username, Strings.toString(builder))); + listener.onFailure(Exceptions.authorizationError( + "Cannot create data frame transform [{}] because user {} lacks all the required permissions for indices: {}", + config.getId(), + username, + indices)); } }