diff --git a/elasticsearch/x-pack/license-plugin/src/main/java/org/elasticsearch/license/plugin/core/LicensesService.java b/elasticsearch/x-pack/license-plugin/src/main/java/org/elasticsearch/license/plugin/core/LicensesService.java index 0eef01be0ea..45b0c39e03d 100644 --- a/elasticsearch/x-pack/license-plugin/src/main/java/org/elasticsearch/license/plugin/core/LicensesService.java +++ b/elasticsearch/x-pack/license-plugin/src/main/java/org/elasticsearch/license/plugin/core/LicensesService.java @@ -174,9 +174,9 @@ public class LicensesService extends AbstractLifecycleComponent } } } - logger.error(builder.toString()); + logger.error("{}", builder); } else { - logger.error(general); + logger.error("{}", general); } } } @@ -206,9 +206,9 @@ public class LicensesService extends AbstractLifecycleComponent } } } - logger.error(builder.toString()); + logger.error("{}", builder.toString()); } else { - logger.error(general); + logger.error("{}", general); } } } @@ -238,9 +238,9 @@ public class LicensesService extends AbstractLifecycleComponent } } } - logger.error(builder.toString()); + logger.error("{}", builder.toString()); } else { - logger.error(general); + logger.error("{}", general); } } } @@ -400,7 +400,7 @@ public class LicensesService extends AbstractLifecycleComponent public void clusterStateProcessed(String source, ClusterState oldState, ClusterState newState) { LicensesMetaData licensesMetaData = newState.metaData().custom(LicensesMetaData.TYPE); if (logger.isDebugEnabled()) { - logger.debug("registered trial license", licensesMetaData); + logger.debug("registered trial license: {}", licensesMetaData); } } diff --git a/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/AbstractLicensesConsumerPluginIntegrationTestCase.java b/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/AbstractLicensesConsumerPluginIntegrationTestCase.java index fa53a4a7b69..c7f076e7551 100644 --- a/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/AbstractLicensesConsumerPluginIntegrationTestCase.java +++ b/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/AbstractLicensesConsumerPluginIntegrationTestCase.java @@ -66,7 +66,7 @@ public abstract class AbstractLicensesConsumerPluginIntegrationTestCase extends } public void testTrialLicenseAndSignedLicenseNotification() throws Exception { - logger.info("using " + consumerPlugin.getClass().getName() + " consumer plugin"); + logger.info("using {} consumer plugin", consumerPlugin.getClass().getName()); logger.info(" --> trial license generated"); // managerService should report feature to be enabled on all data nodes assertLicenseeState(consumerPlugin.id(), LicenseState.ENABLED); diff --git a/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/LicensesPluginIntegrationTests.java b/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/LicensesPluginIntegrationTests.java index cb7e616086c..b8d27360697 100644 --- a/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/LicensesPluginIntegrationTests.java +++ b/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/LicensesPluginIntegrationTests.java @@ -62,7 +62,7 @@ public class LicensesPluginIntegrationTests extends AbstractLicensesIntegrationT } public void testTrialLicenseAndSignedLicenseNotification() throws Exception { - logger.info("using " + ((useEagerLicenseRegistrationPlugin) ? "eager" : "lazy") + " consumer plugin"); + logger.info("using {} consumer plugin", useEagerLicenseRegistrationPlugin ? "eager" : "lazy"); logger.info(" --> trial license generated"); // managerService should report feature to be enabled on all data nodes assertLicenseeState(getCurrentFeatureName(), LicenseState.ENABLED); diff --git a/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/LicensesServiceClusterTests.java b/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/LicensesServiceClusterTests.java index 0f73e6e1a05..f65862a3c64 100644 --- a/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/LicensesServiceClusterTests.java +++ b/elasticsearch/x-pack/license-plugin/src/test/java/org/elasticsearch/license/plugin/LicensesServiceClusterTests.java @@ -80,7 +80,7 @@ public class LicensesServiceClusterTests extends AbstractLicensesIntegrationTest wipeAllLicenses(); int numNodes = randomIntBetween(1, 5); - logger.info("--> starting " + numNodes + " node(s)"); + logger.info("--> starting {} node(s)", numNodes); for (int i = 0; i < numNodes; i++) { internalCluster().startNode(); } diff --git a/elasticsearch/x-pack/marvel/src/main/java/org/elasticsearch/marvel/agent/collector/AbstractCollector.java b/elasticsearch/x-pack/marvel/src/main/java/org/elasticsearch/marvel/agent/collector/AbstractCollector.java index d3d01e2ccec..ba045bfd0bf 100644 --- a/elasticsearch/x-pack/marvel/src/main/java/org/elasticsearch/marvel/agent/collector/AbstractCollector.java +++ b/elasticsearch/x-pack/marvel/src/main/java/org/elasticsearch/marvel/agent/collector/AbstractCollector.java @@ -80,7 +80,7 @@ public abstract class AbstractCollector extends AbstractLifecycleComponent return doCollect(); } } catch (ElasticsearchTimeoutException e) { - logger.error("collector [{}] timed out when collecting data"); + logger.error("collector [{}] timed out when collecting data", name()); } catch (Exception e) { logger.error("collector [{}] - failed collecting data", e, name()); } diff --git a/elasticsearch/x-pack/marvel/src/main/java/org/elasticsearch/marvel/agent/exporter/http/HttpExporter.java b/elasticsearch/x-pack/marvel/src/main/java/org/elasticsearch/marvel/agent/exporter/http/HttpExporter.java index 0d807a27925..21a9ad75c22 100644 --- a/elasticsearch/x-pack/marvel/src/main/java/org/elasticsearch/marvel/agent/exporter/http/HttpExporter.java +++ b/elasticsearch/x-pack/marvel/src/main/java/org/elasticsearch/marvel/agent/exporter/http/HttpExporter.java @@ -271,7 +271,7 @@ public class HttpExporter extends Exporter { try { Version remoteVersion = loadRemoteClusterVersion(host); if (remoteVersion == null) { - logger.warn("unable to check remote cluster version: no version found on host [" + host + "]"); + logger.warn("unable to check remote cluster version: no version found on host [{}]", host); continue; } supportedClusterVersion = remoteVersion.onOrAfter(MIN_SUPPORTED_CLUSTER_VERSION); @@ -361,20 +361,19 @@ public class HttpExporter extends Exporter { return conn; } catch (URISyntaxException e) { - logErrorBasedOnLevel(e, "error parsing host [{}]", host); + logger.error("error parsing host [{}] [{}]", host, e.getMessage()); + if (logger.isDebugEnabled()) { + logger.debug("error parsing host [{}]. full error details:\n[{}]", host, ExceptionsHelper.detailedMessage(e)); + } } catch (IOException e) { - logErrorBasedOnLevel(e, "error connecting to [{}]", host); + logger.error("error connecting to [{}] [{}]", host, e.getMessage()); + if (logger.isDebugEnabled()) { + logger.debug("error connecting to [{}]. full error details:\n[{}]", host, ExceptionsHelper.detailedMessage(e)); + } } return null; } - private void logErrorBasedOnLevel(Throwable t, String msg, Object... params) { - logger.error(msg + " [" + t.getMessage() + "]", params); - if (logger.isDebugEnabled()) { - logger.debug(msg + ". full error details:\n[{}]", params, ExceptionsHelper.detailedMessage(t)); - } - } - /** * Get the version of the remote monitoring cluster */ diff --git a/elasticsearch/x-pack/marvel/src/test/java/org/elasticsearch/marvel/agent/collector/indices/IndexRecoveryCollectorTests.java b/elasticsearch/x-pack/marvel/src/test/java/org/elasticsearch/marvel/agent/collector/indices/IndexRecoveryCollectorTests.java index 587e57a1a2d..6fef3d8c4cf 100644 --- a/elasticsearch/x-pack/marvel/src/test/java/org/elasticsearch/marvel/agent/collector/indices/IndexRecoveryCollectorTests.java +++ b/elasticsearch/x-pack/marvel/src/test/java/org/elasticsearch/marvel/agent/collector/indices/IndexRecoveryCollectorTests.java @@ -74,7 +74,7 @@ public class IndexRecoveryCollectorTests extends AbstractCollectorTestCase { client().prepareIndex(indexName, "foo").setSource("value", randomInt()).get(); } - logger.info("--> create a second index [other] that won't be part of stats collection", indexName, node1); + logger.info("--> create a second index [{}] on node [{}] that won't be part of stats collection", indexName, node1); client().prepareIndex("other", "bar").setSource("value", randomInt()).get(); flushAndRefresh(); diff --git a/elasticsearch/x-pack/shield/src/main/java/org/elasticsearch/shield/action/role/TransportDeleteRoleAction.java b/elasticsearch/x-pack/shield/src/main/java/org/elasticsearch/shield/action/role/TransportDeleteRoleAction.java index ed5ecb136c9..1368ccce33a 100644 --- a/elasticsearch/x-pack/shield/src/main/java/org/elasticsearch/shield/action/role/TransportDeleteRoleAction.java +++ b/elasticsearch/x-pack/shield/src/main/java/org/elasticsearch/shield/action/role/TransportDeleteRoleAction.java @@ -43,7 +43,7 @@ public class TransportDeleteRoleAction extends HandledTransportAction= 6) { assertThat(Validation.ESUsers.validatePassword(passwd.toCharArray()), nullValue()); } else { diff --git a/elasticsearch/x-pack/shield/src/test/java/org/elasticsearch/shield/transport/ServerTransportFilterIntegrationTests.java b/elasticsearch/x-pack/shield/src/test/java/org/elasticsearch/shield/transport/ServerTransportFilterIntegrationTests.java index ed2a575c078..48c60bec691 100644 --- a/elasticsearch/x-pack/shield/src/test/java/org/elasticsearch/shield/transport/ServerTransportFilterIntegrationTests.java +++ b/elasticsearch/x-pack/shield/src/test/java/org/elasticsearch/shield/transport/ServerTransportFilterIntegrationTests.java @@ -156,7 +156,7 @@ public class ServerTransportFilterIntegrationTests extends ShieldIntegTestCase { " master"); } catch (MasterNotDiscoveredException e) { // expected - logger.error("expected: " + e); + logger.error("expected exception", e); } } } diff --git a/elasticsearch/x-pack/watcher/src/main/java/org/elasticsearch/watcher/actions/email/service/Account.java b/elasticsearch/x-pack/watcher/src/main/java/org/elasticsearch/watcher/actions/email/service/Account.java index bed52ce603f..3d418b331e6 100644 --- a/elasticsearch/x-pack/watcher/src/main/java/org/elasticsearch/watcher/actions/email/service/Account.java +++ b/elasticsearch/x-pack/watcher/src/main/java/org/elasticsearch/watcher/actions/email/service/Account.java @@ -126,7 +126,7 @@ public class Account { try { transport.close(); } catch (MessagingException me) { - logger.error("failed to close email transport for account [" + config.name + "]"); + logger.error("failed to close email transport for account [{}]", config.name); } if (contextClassLoader != null) { setContextClassLoader(contextClassLoader); diff --git a/elasticsearch/x-pack/watcher/src/main/java/org/elasticsearch/watcher/actions/email/service/attachment/HttpEmailAttachementParser.java b/elasticsearch/x-pack/watcher/src/main/java/org/elasticsearch/watcher/actions/email/service/attachment/HttpEmailAttachementParser.java index 0516015ec99..b744e7ba8c6 100644 --- a/elasticsearch/x-pack/watcher/src/main/java/org/elasticsearch/watcher/actions/email/service/attachment/HttpEmailAttachementParser.java +++ b/elasticsearch/x-pack/watcher/src/main/java/org/elasticsearch/watcher/actions/email/service/attachment/HttpEmailAttachementParser.java @@ -104,8 +104,8 @@ public class HttpEmailAttachementParser implements EmailAttachmentParserasList(event)); diff --git a/elasticsearch/x-pack/watcher/src/test/java/org/elasticsearch/watcher/trigger/schedule/YearlyScheduleTests.java b/elasticsearch/x-pack/watcher/src/test/java/org/elasticsearch/watcher/trigger/schedule/YearlyScheduleTests.java index eb43bfc830d..aeaec39622a 100644 --- a/elasticsearch/x-pack/watcher/src/test/java/org/elasticsearch/watcher/trigger/schedule/YearlyScheduleTests.java +++ b/elasticsearch/x-pack/watcher/src/test/java/org/elasticsearch/watcher/trigger/schedule/YearlyScheduleTests.java @@ -46,7 +46,7 @@ public class YearlyScheduleTests extends ScheduleTestCase { dayStr = dayStr.replace("32", "L"); String monthStr = Strings.collectionToCommaDelimitedString(time.months()); String expression = "0 " + minStr + " " + hrStr + " " + dayStr + " " + monthStr + " ?"; - logger.info("expression: " + expression); + logger.info("expression: {}", expression); assertThat(crons, hasItemInArray(expression)); } } diff --git a/elasticsearch/x-pack/watcher/src/test/java/org/elasticsearch/watcher/watch/WatchTests.java b/elasticsearch/x-pack/watcher/src/test/java/org/elasticsearch/watcher/watch/WatchTests.java index 8dfa5749660..d75e5201137 100644 --- a/elasticsearch/x-pack/watcher/src/test/java/org/elasticsearch/watcher/watch/WatchTests.java +++ b/elasticsearch/x-pack/watcher/src/test/java/org/elasticsearch/watcher/watch/WatchTests.java @@ -203,7 +203,7 @@ public class WatchTests extends ESTestCase { Watch watch = new Watch("_name", trigger, input, condition, transform, throttlePeriod, actions, metadata, watchStatus); BytesReference bytes = XContentFactory.jsonBuilder().value(watch).bytes(); - logger.info(bytes.toUtf8()); + logger.info("{}", bytes.toUtf8()); Watch.Parser watchParser = new Watch.Parser(settings, conditionRegistry, triggerService, transformRegistry, actionRegistry, inputRegistry, secretService, clock);