honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes wrong password validation 

Now, minimum length of 6 is properly checked

Closes elastic/elasticsearch#441

Original commit: elastic/x-pack-elasticsearch@d644528570
This commit is contained in:
uboness 2014-12-08 14:17:53 +01:00
parent 87a2a2afc6
commit 9970267058
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/elasticsearch/shield/support/Validation.java
View File

@ -28,7 +28,7 @@ public final class Validation {
} }
public static Error validatePassword(char[] password) { public static Error validatePassword(char[] password) {
return password.length > MIN_PASSWD_LENGTH ? return password.length >= MIN_PASSWD_LENGTH ?
null : null :
new Error("passwords must must be at least [" + MIN_PASSWD_LENGTH + "] charachters long"); new Error("passwords must must be at least [" + MIN_PASSWD_LENGTH + "] charachters long");
} }

11
src/test/java/org/elasticsearch/shield/support/ValidationTests.java
View File

@ -63,6 +63,17 @@ public class ValidationTests extends ElasticsearchTestCase {
assertThat(Validation.ESUsers.validateUsername(name), notNullValue()); assertThat(Validation.ESUsers.validateUsername(name), notNullValue());
} }
@Test @Repeat(iterations = 100)
public void testESUsers_validatePassword() throws Exception {
String passwd = randomAsciiOfLength(randomIntBetween(0, 20));
logger.info(passwd + "[{}]", passwd.length());
if (passwd.length() >= 6) {
assertThat(Validation.ESUsers.validatePassword(passwd.toCharArray()), nullValue());
} else {
assertThat(Validation.ESUsers.validatePassword(passwd.toCharArray()), notNullValue());
}
}
@Test @Repeat(iterations = 100) @Test @Repeat(iterations = 100)
public void testRoles_validateRoleName() throws Exception { public void testRoles_validateRoleName() throws Exception {
int length = randomIntBetween(1, 30); int length = randomIntBetween(1, 30);