honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

throw an exception when an action is not found

This commit is contained in:
kimchy 2010-05-26 09:16:10 +03:00
parent 32e4c405de
commit 9a49629d17
2 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
modules/elasticsearch/src/main/java/org/elasticsearch/transport/ActionNotFoundTransportException.java
View File

@ -20,11 +20,20 @@
package org.elasticsearch.transport; package org.elasticsearch.transport;
/** /**
* @author kimchy (Shay Banon) * An exception indicating that a transport action was not found.
*
* @author kimchy (shay.banon)
*/ */
public class ActionNotFoundTransportException extends TransportException { public class ActionNotFoundTransportException extends TransportException {
public ActionNotFoundTransportException(String message) { private final String action;
super(message);
public ActionNotFoundTransportException(String action) {
super("No handler for action [" + action + "]");
this.action = action;
}
public String action() {
return this.action;
} }
} }

2
modules/elasticsearch/src/main/java/org/elasticsearch/transport/netty/MessageChannelHandler.java
View File

@ -164,7 +164,7 @@ public class MessageChannelHandler extends SimpleChannelUpstreamHandler {
try { try {
final TransportRequestHandler handler = transportServiceAdapter.handler(action); final TransportRequestHandler handler = transportServiceAdapter.handler(action);
if (handler == null) { if (handler == null) {
logger.warn("No handler found for action [{}]", action); throw new ActionNotFoundTransportException(action);
} }
final Streamable streamable = handler.newInstance(); final Streamable streamable = handler.newInstance();
streamable.readFrom(buffer); streamable.readFrom(buffer);