honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[TEST] remove unused argument from GeoPolygonQueryBuilderTests#randomPolygon

This commit is contained in:
javanna 2016-08-08 20:04:41 +02:00 committed by Luca Cavanna
parent a73c7e3bf0
commit 9beb82b036
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/test/java/org/elasticsearch/index/query/GeoPolygonQueryBuilderTests.java
View File

@ -51,7 +51,7 @@ import static org.hamcrest.Matchers.equalTo;
public class GeoPolygonQueryBuilderTests extends AbstractQueryTestCase<GeoPolygonQueryBuilder> { public class GeoPolygonQueryBuilderTests extends AbstractQueryTestCase<GeoPolygonQueryBuilder> {
@Override @Override
protected GeoPolygonQueryBuilder doCreateTestQueryBuilder() { protected GeoPolygonQueryBuilder doCreateTestQueryBuilder() {
List<GeoPoint> polygon = randomPolygon(randomIntBetween(4, 50)); List<GeoPoint> polygon = randomPolygon();
GeoPolygonQueryBuilder builder = new GeoPolygonQueryBuilder(GEO_POINT_FIELD_NAME, polygon); GeoPolygonQueryBuilder builder = new GeoPolygonQueryBuilder(GEO_POINT_FIELD_NAME, polygon);
if (randomBoolean()) { if (randomBoolean()) {
builder.setValidationMethod(randomFrom(GeoValidationMethod.values())); builder.setValidationMethod(randomFrom(GeoValidationMethod.values()));
@ -125,7 +125,7 @@ public class GeoPolygonQueryBuilderTests extends AbstractQueryTestCase<GeoPolygo
super.testToQuery(); super.testToQuery();
} }
public List<GeoPoint> randomPolygon(int numPoints) { private static List<GeoPoint> randomPolygon() {
ShapeBuilder shapeBuilder = null; ShapeBuilder shapeBuilder = null;
// This is a temporary fix because sometimes the RandomShapeGenerator // This is a temporary fix because sometimes the RandomShapeGenerator
// returns null. This is if there is an error generating the polygon. So // returns null. This is if there is an error generating the polygon. So
@ -143,7 +143,7 @@ public class GeoPolygonQueryBuilderTests extends AbstractQueryTestCase<GeoPolygo
} }
public void testNullFieldName() { public void testNullFieldName() {
IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> new GeoPolygonQueryBuilder(null, randomPolygon(5))); IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> new GeoPolygonQueryBuilder(null, randomPolygon()));
assertEquals("fieldName must not be null", e.getMessage()); assertEquals("fieldName must not be null", e.getMessage());
} }
@ -370,7 +370,7 @@ public class GeoPolygonQueryBuilderTests extends AbstractQueryTestCase<GeoPolygo
} }
public void testIgnoreUnmapped() throws IOException { public void testIgnoreUnmapped() throws IOException {
List<GeoPoint> polygon = randomPolygon(randomIntBetween(4, 50)); List<GeoPoint> polygon = randomPolygon();
final GeoPolygonQueryBuilder queryBuilder = new GeoPolygonQueryBuilder("unmapped", polygon); final GeoPolygonQueryBuilder queryBuilder = new GeoPolygonQueryBuilder("unmapped", polygon);
queryBuilder.ignoreUnmapped(true); queryBuilder.ignoreUnmapped(true);
Query query = queryBuilder.toQuery(createShardContext()); Query query = queryBuilder.toQuery(createShardContext());