honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-17 10:25:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove extra copy in ScriptDocValues.Strings

Browse Source 
This commit removes a BytesRef copy introduced in #29567 and not
required.

Relates #29567
This commit is contained in:
Jim Ferenczi 2018-04-18 15:13:24 +02:00
parent a548a7f2cb
commit 9d11c7a6c1
1 changed files with 2 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
server/src/main/java/org/elasticsearch/index/fielddata/ScriptDocValues.java
View File

@ -631,28 +631,9 @@ public abstract class ScriptDocValues<T> extends AbstractList<T> {
return values[index].get().utf8ToString();
}
public BytesRef getBytesValue() {
if (size() > 0) {
/**
* We need to make a copy here because {@link BinaryScriptDocValues} might reuse the
* returned value and the same instance might be used to
* return values from multiple documents.
**/
return values[0].toBytesRef();
} else {
return null;
}
}
public String getValue() {
BytesRef value = getBytesValue();
if (value == null) {
return null;
} else {
return value.utf8ToString();
}
return count == 0 ? null : get(0);
}
}
public static final class BytesRefs extends BinaryScriptDocValues<BytesRef> {
@ -672,10 +653,7 @@ public abstract class ScriptDocValues<T> extends AbstractList<T> {
}
public BytesRef getValue() {
if (count == 0) {
return new BytesRef();
}
return values[0].toBytesRef();
return count == 0 ? new BytesRef() : get(0);
}
}