honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Increase IO direct byte buffers to 256KB (#37283) 

Currently we read and write 64KB at a time in the nio libraries. As a
single byte buffer per event loop thread does not consume much memory,
there is little reason to not increase it further. This commit increases
the buffer to 256KB but still limits a single write to 64KB. The write
limit could be increased, but too high of a write limit will lead to
copying more data (if all the data is not flushed and needs to be copied
on the next call). This is something to explore in the future.
This commit is contained in:
Tim Brooks 2019-01-10 09:17:20 -07:00 committed by GitHub
parent 71633775fd
commit 9de62f1262
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/nio/src/main/java/org/elasticsearch/nio/NioSelector.java
View File

@ -69,7 +69,7 @@ public class NioSelector implements Closeable {
public NioSelector(EventHandler eventHandler, Selector selector) { public NioSelector(EventHandler eventHandler, Selector selector) {
this.selector = selector; this.selector = selector;
this.eventHandler = eventHandler; this.eventHandler = eventHandler;
this.ioBuffer = ByteBuffer.allocateDirect(1 << 16); this.ioBuffer = ByteBuffer.allocateDirect(1 << 18);
} }
/** /**

6
libs/nio/src/main/java/org/elasticsearch/nio/SocketChannelContext.java
View File

@ -294,9 +294,14 @@ public abstract class SocketChannelContext extends ChannelContext<SocketChannel>
} }
} }
// Currently we limit to 64KB. This is a trade-off which means more syscalls, in exchange for less
// copying.
private final int WRITE_LIMIT = 1 << 16;
protected int flushToChannel(ByteBuffer buffer) throws IOException { protected int flushToChannel(ByteBuffer buffer) throws IOException {
int initialPosition = buffer.position(); int initialPosition = buffer.position();
ByteBuffer ioBuffer = getSelector().getIoBuffer(); ByteBuffer ioBuffer = getSelector().getIoBuffer();
ioBuffer.limit(Math.min(WRITE_LIMIT, ioBuffer.limit()));
copyBytes(buffer, ioBuffer); copyBytes(buffer, ioBuffer);
ioBuffer.flip(); ioBuffer.flip();
int bytesWritten; int bytesWritten;
@ -318,6 +323,7 @@ public abstract class SocketChannelContext extends ChannelContext<SocketChannel>
int totalBytesFlushed = 0; int totalBytesFlushed = 0;
while (continueFlush) { while (continueFlush) {
ioBuffer.clear(); ioBuffer.clear();
ioBuffer.limit(Math.min(WRITE_LIMIT, ioBuffer.limit()));
int j = 0; int j = 0;
ByteBuffer[] buffers = flushOperation.getBuffersToWrite(); ByteBuffer[] buffers = flushOperation.getBuffersToWrite();
while (j < buffers.length && ioBuffer.remaining() > 0) { while (j < buffers.length && ioBuffer.remaining() > 0) {