honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix exception check in RecoveryRequestTrackerTests (#57493) 

Currently we check that exceptions are the same in the recovery request
tracker test. This is inconsistent because the future wraps the
exception in a new instance. This commit fixes the test by comparing a
random exception message.

Fixes #57199
This commit is contained in:
Tim Brooks 2020-06-02 16:47:11 -06:00
parent fe2eaf0d03
commit 9eaee3da8d
No known key found for this signature in database
GPG Key ID: C2AA3BB91A889E77
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server/src/test/java/org/elasticsearch/indices/recovery/RecoveryRequestTrackerTests.java
View File

@ -19,6 +19,7 @@
package org.elasticsearch.indices.recovery;
import org.elasticsearch.ElasticsearchException;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.action.support.PlainActionFuture;
import org.elasticsearch.common.util.concurrent.ConcurrentCollections;
@ -68,7 +69,7 @@ public class RecoveryRequestTrackerTests extends ESTestCase {
// Ensure that we only return 1 future per sequence number
assertTrue(added);
if (rarely()) {
listener.onFailure(new Exception());
listener.onFailure(new ElasticsearchException(randomAlphaOfLength(10)));
} else {
listener.onResponse(null);
}
@ -103,7 +104,7 @@ public class RecoveryRequestTrackerTests extends ESTestCase {
future.actionGet();
fail("expected exception");
} catch (Exception e) {
assertSame(e, expectedException);
assertEquals(expectedException.getMessage(), e.getMessage());
}
}
}