diff --git a/core/src/main/java/org/elasticsearch/index/query/NotQueryParser.java b/core/src/main/java/org/elasticsearch/index/query/NotQueryParser.java index 2388eb13999..f37ea48a330 100644 --- a/core/src/main/java/org/elasticsearch/index/query/NotQueryParser.java +++ b/core/src/main/java/org/elasticsearch/index/query/NotQueryParser.java @@ -30,7 +30,7 @@ import java.io.IOException; */ public class NotQueryParser extends BaseQueryParser { - private static final ParseField QUERY_FIELD = new ParseField("filter", "query"); + private static final ParseField QUERY_FIELD = new ParseField("query", "filter"); @Inject public NotQueryParser() { diff --git a/core/src/test/java/org/elasticsearch/index/query/BaseQueryTestCase.java b/core/src/test/java/org/elasticsearch/index/query/AbstractQueryTestCase.java similarity index 91% rename from core/src/test/java/org/elasticsearch/index/query/BaseQueryTestCase.java rename to core/src/test/java/org/elasticsearch/index/query/AbstractQueryTestCase.java index 87bd6f32e17..80a0e2bc077 100644 --- a/core/src/test/java/org/elasticsearch/index/query/BaseQueryTestCase.java +++ b/core/src/test/java/org/elasticsearch/index/query/AbstractQueryTestCase.java @@ -89,7 +89,7 @@ import static org.hamcrest.Matchers.not; import static org.hamcrest.Matchers.notNullValue; import static org.hamcrest.Matchers.nullValue; -public abstract class BaseQueryTestCase> extends ESTestCase { // TODO rename this AbstractQueryTestCase +public abstract class AbstractQueryTestCase> extends ESTestCase { private static final GeohashGenerator geohashGenerator = new GeohashGenerator(); protected static final String STRING_FIELD_NAME = "mapped_string"; @@ -126,6 +126,8 @@ public abstract class BaseQueryTestCase> ext private static NamedWriteableRegistry namedWriteableRegistry; + private static String[] randomTypes; + /** * Setup for the whole base test class. * @throws IOException @@ -135,7 +137,7 @@ public abstract class BaseQueryTestCase> ext // we have to prefer CURRENT since with the range of versions we support it's rather unlikely to get the current actually. Version version = randomBoolean() ? Version.CURRENT : VersionUtils.randomVersionBetween(random(), Version.V_2_0_0_beta1, Version.CURRENT); Settings settings = Settings.settingsBuilder() - .put("name", BaseQueryTestCase.class.toString()) + .put("name", AbstractQueryTestCase.class.toString()) .put("path.home", createTempDir()) .build(); Settings indexSettings = Settings.settingsBuilder() @@ -203,19 +205,13 @@ public abstract class BaseQueryTestCase> ext queryParserService = null; currentTypes = null; namedWriteableRegistry = null; + randomTypes = null; } @Before public void beforeTest() { //set some random types to be queried as part the search request, before each test - String[] types = getRandomTypes(); - //some query (e.g. range query) have a different behaviour depending on whether the current search context is set or not - //which is why we randomly set the search context, which will internally also do QueryParseContext.setTypes(types) - if (randomBoolean()) { - QueryShardContext.setTypes(types); - } else { - setSearchContext(types); // TODO should this be set after we parsed and before we build the query? it makes more sense? - } + randomTypes = getRandomTypes(); } protected void setSearchContext(String[] types) { @@ -258,7 +254,7 @@ public abstract class BaseQueryTestCase> ext QB testQuery = createTestQueryBuilder(); assertParsedQuery(testQuery.toString(), testQuery); for (Map.Entry alternateVersion : getAlternateVersions().entrySet()) { - assertParsedQuery(alternateVersion.getKey(), alternateVersion.getValue()); + assertParsedQuery(alternateVersion.getKey(), alternateVersion.getValue(), ParseFieldMatcher.EMPTY); } } @@ -274,21 +270,38 @@ public abstract class BaseQueryTestCase> ext * Parses the query provided as string argument and compares it with the expected result provided as argument as a {@link QueryBuilder} */ protected void assertParsedQuery(String queryAsString, QueryBuilder expectedQuery) throws IOException { - QueryBuilder newQuery = parseQuery(queryAsString); + assertParsedQuery(queryAsString, expectedQuery, getDefaultParseFieldMatcher()); + } + + protected void assertParsedQuery(String queryAsString, QueryBuilder expectedQuery, ParseFieldMatcher matcher) throws IOException { + QueryBuilder newQuery = parseQuery(queryAsString, matcher); assertNotSame(newQuery, expectedQuery); assertEquals(expectedQuery, newQuery); assertEquals(expectedQuery.hashCode(), newQuery.hashCode()); } protected QueryBuilder parseQuery(String queryAsString) throws IOException { + return parseQuery(queryAsString, getDefaultParseFieldMatcher()); + } + + protected QueryBuilder parseQuery(String queryAsString, ParseFieldMatcher matcher) throws IOException { XContentParser parser = XContentFactory.xContent(queryAsString).createParser(queryAsString); QueryParseContext context = createParseContext(); context.reset(parser); - // TODO this should set context.parseFieldMatcher(ParseFieldMatcher.STRICT); - // all our builders should only create non-deprecated XContent. + context.parseFieldMatcher(matcher); return context.parseInnerQueryBuilder(); } + /** + * Returns the default {@link ParseFieldMatcher} used for parsing non-alternative XContent representations. + * The default is {@link ParseFieldMatcher#STRICT}. + * Note: Queries returned from {@link #getAlternateVersions()} are always parsed with {@link ParseFieldMatcher#EMPTY} as they might + * not be backwards compatible. + */ + protected ParseFieldMatcher getDefaultParseFieldMatcher() { + return ParseFieldMatcher.STRICT; + } + /** * Test creates the {@link Query} from the {@link QueryBuilder} under test and delegates the * assertions being made on the result to the implementing subclass. @@ -299,22 +312,30 @@ public abstract class BaseQueryTestCase> ext context.setAllowUnmappedFields(true); QB firstQuery = createTestQueryBuilder(); + setSearchContext(randomTypes); // only set search context for toQuery to be more realistic Query firstLuceneQuery = firstQuery.toQuery(context); assertLuceneQuery(firstQuery, firstLuceneQuery, context); + SearchContext.removeCurrent(); // remove after assertLuceneQuery since the assertLuceneQuery impl might access the context as well + QB secondQuery = copyQuery(firstQuery); //query _name never should affect the result of toQuery, we randomly set it to make sure if (randomBoolean()) { secondQuery.queryName(secondQuery.queryName() == null ? randomAsciiOfLengthBetween(1, 30) : secondQuery.queryName() + randomAsciiOfLengthBetween(1, 10)); } + setSearchContext(randomTypes); // only set search context for toQuery to be more realistic Query secondLuceneQuery = secondQuery.toQuery(context); assertLuceneQuery(secondQuery, secondLuceneQuery, context); + SearchContext.removeCurrent(); // remove after assertLuceneQuery since the assertLuceneQuery impl might access the context as well + assertThat("two equivalent query builders lead to different lucene queries", secondLuceneQuery, equalTo(firstLuceneQuery)); //if the initial lucene query is null, changing its boost won't have any effect, we shouldn't test that if (firstLuceneQuery != null && supportsBoostAndQueryName()) { secondQuery.boost(firstQuery.boost() + 1f + randomFloat()); + setSearchContext(randomTypes); // only set search context for toQuery to be more realistic Query thirdLuceneQuery = secondQuery.toQuery(context); + SearchContext.removeCurrent(); assertThat("modifying the boost doesn't affect the corresponding lucene query", firstLuceneQuery, not(equalTo(thirdLuceneQuery))); } } @@ -451,9 +472,9 @@ public abstract class BaseQueryTestCase> ext } /** - * create a random value for either {@link BaseQueryTestCase#BOOLEAN_FIELD_NAME}, {@link BaseQueryTestCase#INT_FIELD_NAME}, - * {@link BaseQueryTestCase#DOUBLE_FIELD_NAME}, {@link BaseQueryTestCase#STRING_FIELD_NAME} or - * {@link BaseQueryTestCase#DATE_FIELD_NAME}, or a String value by default + * create a random value for either {@link AbstractQueryTestCase#BOOLEAN_FIELD_NAME}, {@link AbstractQueryTestCase#INT_FIELD_NAME}, + * {@link AbstractQueryTestCase#DOUBLE_FIELD_NAME}, {@link AbstractQueryTestCase#STRING_FIELD_NAME} or + * {@link AbstractQueryTestCase#DATE_FIELD_NAME}, or a String value by default */ protected static Object getRandomValueForFieldName(String fieldName) { Object value; diff --git a/core/src/test/java/org/elasticsearch/index/query/BaseTermQueryTestCase.java b/core/src/test/java/org/elasticsearch/index/query/AbstractTermQueryTestCase.java similarity index 97% rename from core/src/test/java/org/elasticsearch/index/query/BaseTermQueryTestCase.java rename to core/src/test/java/org/elasticsearch/index/query/AbstractTermQueryTestCase.java index c83a3f5f2c2..3c63fdf3d9d 100644 --- a/core/src/test/java/org/elasticsearch/index/query/BaseTermQueryTestCase.java +++ b/core/src/test/java/org/elasticsearch/index/query/AbstractTermQueryTestCase.java @@ -26,7 +26,7 @@ import java.util.Map; import static org.hamcrest.Matchers.is; -public abstract class BaseTermQueryTestCase> extends BaseQueryTestCase { +public abstract class AbstractTermQueryTestCase> extends AbstractQueryTestCase { @Override protected final QB doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/AndQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/AndQueryBuilderTests.java index e18495b9562..ae55678cd66 100644 --- a/core/src/test/java/org/elasticsearch/index/query/AndQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/AndQueryBuilderTests.java @@ -30,7 +30,7 @@ import java.util.*; import static org.hamcrest.CoreMatchers.*; @SuppressWarnings("deprecation") -public class AndQueryBuilderTests extends BaseQueryTestCase { +public class AndQueryBuilderTests extends AbstractQueryTestCase { /** * @return a AndQueryBuilder with random limit between 0 and 20 diff --git a/core/src/test/java/org/elasticsearch/index/query/BoolQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/BoolQueryBuilderTests.java index f11e82a808e..59c305c3014 100644 --- a/core/src/test/java/org/elasticsearch/index/query/BoolQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/BoolQueryBuilderTests.java @@ -31,7 +31,7 @@ import java.util.*; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class BoolQueryBuilderTests extends BaseQueryTestCase { +public class BoolQueryBuilderTests extends AbstractQueryTestCase { @Override protected BoolQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/BoostingQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/BoostingQueryBuilderTests.java index fdff0c35269..6bb895cb1b9 100644 --- a/core/src/test/java/org/elasticsearch/index/query/BoostingQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/BoostingQueryBuilderTests.java @@ -28,7 +28,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.instanceOf; import static org.hamcrest.CoreMatchers.nullValue; -public class BoostingQueryBuilderTests extends BaseQueryTestCase { +public class BoostingQueryBuilderTests extends AbstractQueryTestCase { @Override protected BoostingQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/CommonTermsQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/CommonTermsQueryBuilderTests.java index 7d5a927e258..44b5fd97c95 100644 --- a/core/src/test/java/org/elasticsearch/index/query/CommonTermsQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/CommonTermsQueryBuilderTests.java @@ -29,7 +29,7 @@ import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.is; -public class CommonTermsQueryBuilderTests extends BaseQueryTestCase { +public class CommonTermsQueryBuilderTests extends AbstractQueryTestCase { @Override protected CommonTermsQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/ConstantScoreQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/ConstantScoreQueryBuilderTests.java index 7e3e48e16fc..fedfce3bb71 100644 --- a/core/src/test/java/org/elasticsearch/index/query/ConstantScoreQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/ConstantScoreQueryBuilderTests.java @@ -27,7 +27,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.*; -public class ConstantScoreQueryBuilderTests extends BaseQueryTestCase { +public class ConstantScoreQueryBuilderTests extends AbstractQueryTestCase { /** * @return a {@link ConstantScoreQueryBuilder} with random boost between 0.1f and 2.0f diff --git a/core/src/test/java/org/elasticsearch/index/query/DisMaxQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/DisMaxQueryBuilderTests.java index 49998145630..ee32963bf80 100644 --- a/core/src/test/java/org/elasticsearch/index/query/DisMaxQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/DisMaxQueryBuilderTests.java @@ -31,7 +31,7 @@ import java.util.Map; import static org.hamcrest.CoreMatchers.*; -public class DisMaxQueryBuilderTests extends BaseQueryTestCase { +public class DisMaxQueryBuilderTests extends AbstractQueryTestCase { /** * @return a {@link DisMaxQueryBuilder} with random inner queries diff --git a/core/src/test/java/org/elasticsearch/index/query/ExistsQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/ExistsQueryBuilderTests.java index 6b6615d91ea..ed5f012a305 100644 --- a/core/src/test/java/org/elasticsearch/index/query/ExistsQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/ExistsQueryBuilderTests.java @@ -32,7 +32,7 @@ import java.util.Collection; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class ExistsQueryBuilderTests extends BaseQueryTestCase { +public class ExistsQueryBuilderTests extends AbstractQueryTestCase { @Override protected ExistsQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/FQueryFilterBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/FQueryFilterBuilderTests.java index 40925658634..19e0db5127b 100644 --- a/core/src/test/java/org/elasticsearch/index/query/FQueryFilterBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/FQueryFilterBuilderTests.java @@ -28,7 +28,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.*; @SuppressWarnings("deprecation") -public class FQueryFilterBuilderTests extends BaseQueryTestCase { +public class FQueryFilterBuilderTests extends AbstractQueryTestCase { /** * @return a FQueryFilterBuilder with random inner query diff --git a/core/src/test/java/org/elasticsearch/index/query/FieldMaskingSpanQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/FieldMaskingSpanQueryBuilderTests.java index fc0a2acae9c..60b139face9 100644 --- a/core/src/test/java/org/elasticsearch/index/query/FieldMaskingSpanQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/FieldMaskingSpanQueryBuilderTests.java @@ -29,7 +29,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class FieldMaskingSpanQueryBuilderTests extends BaseQueryTestCase { +public class FieldMaskingSpanQueryBuilderTests extends AbstractQueryTestCase { @Override protected FieldMaskingSpanQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/FilteredQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/FilteredQueryBuilderTests.java index 4d6036dd761..5a6a528b2df 100644 --- a/core/src/test/java/org/elasticsearch/index/query/FilteredQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/FilteredQueryBuilderTests.java @@ -31,7 +31,7 @@ import static org.hamcrest.CoreMatchers.instanceOf; import static org.hamcrest.CoreMatchers.nullValue; @SuppressWarnings("deprecation") -public class FilteredQueryBuilderTests extends BaseQueryTestCase { +public class FilteredQueryBuilderTests extends AbstractQueryTestCase { @Override protected FilteredQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/FuzzyQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/FuzzyQueryBuilderTests.java index d74b442230b..3f772fdcdee 100644 --- a/core/src/test/java/org/elasticsearch/index/query/FuzzyQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/FuzzyQueryBuilderTests.java @@ -32,7 +32,7 @@ import java.io.IOException; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.is; -public class FuzzyQueryBuilderTests extends BaseQueryTestCase { +public class FuzzyQueryBuilderTests extends AbstractQueryTestCase { @Override protected FuzzyQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/GeoDistanceRangeQueryTests.java b/core/src/test/java/org/elasticsearch/index/query/GeoDistanceRangeQueryTests.java index cba0ab7b215..6fd1728e81f 100644 --- a/core/src/test/java/org/elasticsearch/index/query/GeoDistanceRangeQueryTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/GeoDistanceRangeQueryTests.java @@ -34,7 +34,7 @@ import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.notNullValue; -public class GeoDistanceRangeQueryTests extends BaseQueryTestCase { +public class GeoDistanceRangeQueryTests extends AbstractQueryTestCase { @Override protected GeoDistanceRangeQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/GeohashCellQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/GeohashCellQueryBuilderTests.java index 5a408631cba..48faac3f1e1 100644 --- a/core/src/test/java/org/elasticsearch/index/query/GeohashCellQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/GeohashCellQueryBuilderTests.java @@ -34,7 +34,7 @@ import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.notNullValue; -public class GeohashCellQueryBuilderTests extends BaseQueryTestCase { +public class GeohashCellQueryBuilderTests extends AbstractQueryTestCase { @Override protected Builder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/HasChildQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/HasChildQueryBuilderTests.java index 26a202a3fa9..b6ff913d068 100644 --- a/core/src/test/java/org/elasticsearch/index/query/HasChildQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/HasChildQueryBuilderTests.java @@ -40,7 +40,7 @@ import java.io.IOException; import static org.elasticsearch.test.StreamsUtils.copyToStringFromClasspath; import static org.hamcrest.CoreMatchers.instanceOf; -public class HasChildQueryBuilderTests extends BaseQueryTestCase { +public class HasChildQueryBuilderTests extends AbstractQueryTestCase { protected static final String PARENT_TYPE = "parent"; protected static final String CHILD_TYPE = "child"; @@ -108,7 +108,7 @@ public class HasChildQueryBuilderTests extends BaseQueryTestCase { +public class HasParentQueryBuilderTests extends AbstractQueryTestCase { protected static final String PARENT_TYPE = "parent"; protected static final String CHILD_TYPE = "child"; @@ -105,7 +105,7 @@ public class HasParentQueryBuilderTests extends BaseQueryTestCase { +public class IdsQueryBuilderTests extends AbstractQueryTestCase { /** * check that parser throws exception on missing values field diff --git a/core/src/test/java/org/elasticsearch/index/query/IndicesQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/IndicesQueryBuilderTests.java index 9abdfca8752..9990b513d3a 100644 --- a/core/src/test/java/org/elasticsearch/index/query/IndicesQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/IndicesQueryBuilderTests.java @@ -24,7 +24,7 @@ import org.junit.Test; import java.io.IOException; -public class IndicesQueryBuilderTests extends BaseQueryTestCase { +public class IndicesQueryBuilderTests extends AbstractQueryTestCase { @Override protected IndicesQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/LimitQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/LimitQueryBuilderTests.java index dfb47160da3..8567505aded 100644 --- a/core/src/test/java/org/elasticsearch/index/query/LimitQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/LimitQueryBuilderTests.java @@ -26,7 +26,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.instanceOf; -public class LimitQueryBuilderTests extends BaseQueryTestCase { +public class LimitQueryBuilderTests extends AbstractQueryTestCase { /** * @return a LimitQueryBuilder with random limit between 0 and 20 diff --git a/core/src/test/java/org/elasticsearch/index/query/MatchAllQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/MatchAllQueryBuilderTests.java index 5603997abc6..160385593a4 100644 --- a/core/src/test/java/org/elasticsearch/index/query/MatchAllQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/MatchAllQueryBuilderTests.java @@ -26,7 +26,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.instanceOf; -public class MatchAllQueryBuilderTests extends BaseQueryTestCase { +public class MatchAllQueryBuilderTests extends AbstractQueryTestCase { @Override protected MatchAllQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/MatchNoneQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/MatchNoneQueryBuilderTests.java index 1511243f109..cb80f31599a 100644 --- a/core/src/test/java/org/elasticsearch/index/query/MatchNoneQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/MatchNoneQueryBuilderTests.java @@ -27,7 +27,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class MatchNoneQueryBuilderTests extends BaseQueryTestCase { +public class MatchNoneQueryBuilderTests extends AbstractQueryTestCase { @Override protected boolean supportsBoostAndQueryName() { diff --git a/core/src/test/java/org/elasticsearch/index/query/MissingQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/MissingQueryBuilderTests.java index d5fe75c0199..7a7fba3a4eb 100644 --- a/core/src/test/java/org/elasticsearch/index/query/MissingQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/MissingQueryBuilderTests.java @@ -26,7 +26,7 @@ import java.io.IOException; import static org.hamcrest.Matchers.is; -public class MissingQueryBuilderTests extends BaseQueryTestCase { +public class MissingQueryBuilderTests extends AbstractQueryTestCase { @Override protected MissingQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/NotQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/NotQueryBuilderTests.java index 5cd870c7df4..ee74e9a6112 100644 --- a/core/src/test/java/org/elasticsearch/index/query/NotQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/NotQueryBuilderTests.java @@ -31,7 +31,7 @@ import java.util.Map; import static org.hamcrest.CoreMatchers.*; -public class NotQueryBuilderTests extends BaseQueryTestCase { +public class NotQueryBuilderTests extends AbstractQueryTestCase { /** * @return a NotQueryBuilder with random limit between 0 and 20 diff --git a/core/src/test/java/org/elasticsearch/index/query/OrQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/OrQueryBuilderTests.java index e1904318b9e..1c4c38e2c64 100644 --- a/core/src/test/java/org/elasticsearch/index/query/OrQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/OrQueryBuilderTests.java @@ -30,7 +30,7 @@ import java.util.*; import static org.hamcrest.CoreMatchers.*; @SuppressWarnings("deprecation") -public class OrQueryBuilderTests extends BaseQueryTestCase { +public class OrQueryBuilderTests extends AbstractQueryTestCase { /** * @return an OrQueryBuilder with random limit between 0 and 20 diff --git a/core/src/test/java/org/elasticsearch/index/query/PrefixQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/PrefixQueryBuilderTests.java index b5ebe4b9e39..31174629aaa 100644 --- a/core/src/test/java/org/elasticsearch/index/query/PrefixQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/PrefixQueryBuilderTests.java @@ -29,7 +29,7 @@ import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.is; -public class PrefixQueryBuilderTests extends BaseQueryTestCase { +public class PrefixQueryBuilderTests extends AbstractQueryTestCase { @Override protected PrefixQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/QueryFilterBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/QueryFilterBuilderTests.java index 6530e65d310..c26fd9b0ab8 100644 --- a/core/src/test/java/org/elasticsearch/index/query/QueryFilterBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/QueryFilterBuilderTests.java @@ -28,7 +28,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.*; @SuppressWarnings("deprecation") -public class QueryFilterBuilderTests extends BaseQueryTestCase { +public class QueryFilterBuilderTests extends AbstractQueryTestCase { @Override protected QueryFilterBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/RandomQueryBuilder.java b/core/src/test/java/org/elasticsearch/index/query/RandomQueryBuilder.java index f7157f292cf..a25a7a3dcea 100644 --- a/core/src/test/java/org/elasticsearch/index/query/RandomQueryBuilder.java +++ b/core/src/test/java/org/elasticsearch/index/query/RandomQueryBuilder.java @@ -62,7 +62,7 @@ public class RandomQueryBuilder { // for now, only use String Rangequeries for MultiTerm test, numeric and date makes little sense // see issue #12123 for discussion // Prefix / Fuzzy / RegEx / Wildcard can go here later once refactored and they have random query generators - RangeQueryBuilder query = new RangeQueryBuilder(BaseQueryTestCase.STRING_FIELD_NAME); + RangeQueryBuilder query = new RangeQueryBuilder(AbstractQueryTestCase.STRING_FIELD_NAME); query.from("a" + RandomStrings.randomAsciiOfLengthBetween(r, 1, 10)); query.to("z" + RandomStrings.randomAsciiOfLengthBetween(r, 1, 10)); return query; diff --git a/core/src/test/java/org/elasticsearch/index/query/RangeQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/RangeQueryBuilderTests.java index 77b8c130ce0..3ad2b788339 100644 --- a/core/src/test/java/org/elasticsearch/index/query/RangeQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/RangeQueryBuilderTests.java @@ -31,7 +31,7 @@ import java.io.IOException; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.is; -public class RangeQueryBuilderTests extends BaseQueryTestCase { +public class RangeQueryBuilderTests extends AbstractQueryTestCase { @Override protected RangeQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/RegexpQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/RegexpQueryBuilderTests.java index ee4ef0ffe49..75edf29a193 100644 --- a/core/src/test/java/org/elasticsearch/index/query/RegexpQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/RegexpQueryBuilderTests.java @@ -30,7 +30,7 @@ import java.util.List; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.is; -public class RegexpQueryBuilderTests extends BaseQueryTestCase { +public class RegexpQueryBuilderTests extends AbstractQueryTestCase { @Override protected RegexpQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/ScriptQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/ScriptQueryBuilderTests.java index b216418e584..4cacd657db2 100644 --- a/core/src/test/java/org/elasticsearch/index/query/ScriptQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/ScriptQueryBuilderTests.java @@ -31,7 +31,7 @@ import java.util.Map; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.is; -public class ScriptQueryBuilderTests extends BaseQueryTestCase { +public class ScriptQueryBuilderTests extends AbstractQueryTestCase { @Override protected ScriptQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java index be0913184d4..956230e8381 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java @@ -32,7 +32,7 @@ import java.util.*; import static org.hamcrest.Matchers.*; -public class SimpleQueryStringBuilderTests extends BaseQueryTestCase { +public class SimpleQueryStringBuilderTests extends AbstractQueryTestCase { @Override protected SimpleQueryStringBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/SpanContainingQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SpanContainingQueryBuilderTests.java index 5938c3157b3..75a4ab9f06f 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SpanContainingQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SpanContainingQueryBuilderTests.java @@ -28,7 +28,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class SpanContainingQueryBuilderTests extends BaseQueryTestCase { +public class SpanContainingQueryBuilderTests extends AbstractQueryTestCase { @Override protected SpanContainingQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/SpanFirstQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SpanFirstQueryBuilderTests.java index 343c203afb9..cd9ca8287f4 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SpanFirstQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SpanFirstQueryBuilderTests.java @@ -30,7 +30,7 @@ import java.io.IOException; import static org.elasticsearch.index.query.QueryBuilders.spanTermQuery; import static org.hamcrest.CoreMatchers.instanceOf; -public class SpanFirstQueryBuilderTests extends BaseQueryTestCase { +public class SpanFirstQueryBuilderTests extends AbstractQueryTestCase { @Override protected SpanFirstQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/SpanMultiTermQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SpanMultiTermQueryBuilderTests.java index 79c98fd0ce2..52551ae5b74 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SpanMultiTermQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SpanMultiTermQueryBuilderTests.java @@ -29,7 +29,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class SpanMultiTermQueryBuilderTests extends BaseQueryTestCase { +public class SpanMultiTermQueryBuilderTests extends AbstractQueryTestCase { @Override protected SpanMultiTermQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/SpanNearQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SpanNearQueryBuilderTests.java index e8ce6c5daf2..f9c9e32405b 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SpanNearQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SpanNearQueryBuilderTests.java @@ -30,7 +30,7 @@ import java.util.Iterator; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class SpanNearQueryBuilderTests extends BaseQueryTestCase { +public class SpanNearQueryBuilderTests extends AbstractQueryTestCase { @Override protected SpanNearQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/SpanNotQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SpanNotQueryBuilderTests.java index 7d5f45079bb..49d1a9e4496 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SpanNotQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SpanNotQueryBuilderTests.java @@ -31,7 +31,7 @@ import static org.elasticsearch.index.query.QueryBuilders.spanNearQuery; import static org.elasticsearch.index.query.QueryBuilders.spanTermQuery; import static org.hamcrest.Matchers.*; -public class SpanNotQueryBuilderTests extends BaseQueryTestCase { +public class SpanNotQueryBuilderTests extends AbstractQueryTestCase { @Override protected SpanNotQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/SpanOrQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SpanOrQueryBuilderTests.java index a83610be5bd..bc4519a48b4 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SpanOrQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SpanOrQueryBuilderTests.java @@ -30,7 +30,7 @@ import java.util.Iterator; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class SpanOrQueryBuilderTests extends BaseQueryTestCase { +public class SpanOrQueryBuilderTests extends AbstractQueryTestCase { @Override protected SpanOrQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/SpanTermQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SpanTermQueryBuilderTests.java index 41631dfecb3..a51efc6f985 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SpanTermQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SpanTermQueryBuilderTests.java @@ -30,7 +30,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class SpanTermQueryBuilderTests extends BaseTermQueryTestCase { +public class SpanTermQueryBuilderTests extends AbstractTermQueryTestCase { @Override protected SpanTermQueryBuilder createQueryBuilder(String fieldName, Object value) { diff --git a/core/src/test/java/org/elasticsearch/index/query/SpanWithinQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SpanWithinQueryBuilderTests.java index 0e22f26c09b..9d18e9ed373 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SpanWithinQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SpanWithinQueryBuilderTests.java @@ -28,7 +28,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class SpanWithinQueryBuilderTests extends BaseQueryTestCase { +public class SpanWithinQueryBuilderTests extends AbstractQueryTestCase { @Override protected SpanWithinQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/TemplateQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/TemplateQueryBuilderTests.java index 8dc2a61c110..00e980c0380 100644 --- a/core/src/test/java/org/elasticsearch/index/query/TemplateQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/TemplateQueryBuilderTests.java @@ -33,7 +33,7 @@ import java.util.Map; import static org.hamcrest.Matchers.is; -public class TemplateQueryBuilderTests extends BaseQueryTestCase { +public class TemplateQueryBuilderTests extends AbstractQueryTestCase { /** * The query type all template tests will be based on. diff --git a/core/src/test/java/org/elasticsearch/index/query/TermQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/TermQueryBuilderTests.java index 5c8146d5195..b2a8410bdde 100644 --- a/core/src/test/java/org/elasticsearch/index/query/TermQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/TermQueryBuilderTests.java @@ -30,7 +30,7 @@ import java.io.IOException; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; -public class TermQueryBuilderTests extends BaseTermQueryTestCase { +public class TermQueryBuilderTests extends AbstractTermQueryTestCase { /** * @return a TermQuery with random field name and value, optional random boost and queryname diff --git a/core/src/test/java/org/elasticsearch/index/query/TermsQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/TermsQueryBuilderTests.java index cd8d8b141b0..9d9aeb536f3 100644 --- a/core/src/test/java/org/elasticsearch/index/query/TermsQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/TermsQueryBuilderTests.java @@ -24,6 +24,7 @@ import org.apache.lucene.search.BooleanClause; import org.apache.lucene.search.BooleanQuery; import org.apache.lucene.search.Query; import org.apache.lucene.search.TermQuery; +import org.elasticsearch.common.ParseFieldMatcher; import org.elasticsearch.common.settings.Settings; import org.elasticsearch.index.search.termslookup.TermsLookupFetchService; import org.elasticsearch.indices.cache.query.terms.TermsLookup; @@ -38,7 +39,7 @@ import java.util.List; import static org.hamcrest.Matchers.*; -public class TermsQueryBuilderTests extends BaseQueryTestCase { +public class TermsQueryBuilderTests extends AbstractQueryTestCase { private MockTermsLookupFetchService termsLookupFetchService; @@ -48,6 +49,11 @@ public class TermsQueryBuilderTests extends BaseQueryTestCase queryParserService().setTermsLookupFetchService(termsLookupFetchService); } + @Override + protected ParseFieldMatcher getDefaultParseFieldMatcher() { + return ParseFieldMatcher.EMPTY; + } + @Override protected TermsQueryBuilder doCreateTestQueryBuilder() { TermsQueryBuilder query; diff --git a/core/src/test/java/org/elasticsearch/index/query/TypeQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/TypeQueryBuilderTests.java index 0ed327a51da..46af02fbad6 100644 --- a/core/src/test/java/org/elasticsearch/index/query/TypeQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/TypeQueryBuilderTests.java @@ -29,7 +29,7 @@ import java.io.IOException; import static org.hamcrest.Matchers.*; -public class TypeQueryBuilderTests extends BaseQueryTestCase { +public class TypeQueryBuilderTests extends AbstractQueryTestCase { @Override protected TypeQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/WildcardQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/WildcardQueryBuilderTests.java index 39f71870db8..18bd4893bf8 100644 --- a/core/src/test/java/org/elasticsearch/index/query/WildcardQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/WildcardQueryBuilderTests.java @@ -28,7 +28,7 @@ import java.io.IOException; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.is; -public class WildcardQueryBuilderTests extends BaseQueryTestCase { +public class WildcardQueryBuilderTests extends AbstractQueryTestCase { @Override protected WildcardQueryBuilder doCreateTestQueryBuilder() { diff --git a/core/src/test/java/org/elasticsearch/index/query/WrapperQueryBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/WrapperQueryBuilderTests.java index 3e9317da6be..ab80378cb86 100644 --- a/core/src/test/java/org/elasticsearch/index/query/WrapperQueryBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/WrapperQueryBuilderTests.java @@ -29,7 +29,7 @@ import java.io.IOException; import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.is; -public class WrapperQueryBuilderTests extends BaseQueryTestCase { +public class WrapperQueryBuilderTests extends AbstractQueryTestCase { @Override protected boolean supportsBoostAndQueryName() {