honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Tests] Improve error message for failed xContentEquivalent() tests (#24828) 

For comparing actual and parsed object equality for the response parsing we
currently rely on comparing the original xContent and the output of the parsed 
object. Currently we only have cryptic error messages if this comparison fails 
which are hard to read also because we recursively compare lists and maps of 
the xContent structures we compare.

This commits leverages the existing NotEqualMessageBuilder for providing error 
messages  that are more detailed and useful for debugging if an error occurs.
This commit is contained in:
Christoph Büscher 2017-06-01 14:12:26 +02:00 committed by GitHub
parent 1775e4253e
commit a94ac30360
2 changed files with 171 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/framework/src/main/java/org/elasticsearch/test/hamcrest/ElasticsearchAssertions.java
View File

@ -65,6 +65,7 @@ import org.elasticsearch.search.SearchHit;
import org.elasticsearch.search.SearchModule; import org.elasticsearch.search.SearchModule;
import org.elasticsearch.search.suggest.Suggest; import org.elasticsearch.search.suggest.Suggest;
import org.elasticsearch.test.ESIntegTestCase; import org.elasticsearch.test.ESIntegTestCase;
import org.elasticsearch.test.NotEqualMessageBuilder;
import org.elasticsearch.test.VersionUtils; import org.elasticsearch.test.VersionUtils;
import org.hamcrest.CoreMatchers; import org.hamcrest.CoreMatchers;
import org.hamcrest.Matcher; import org.hamcrest.Matcher;
@ -790,11 +791,19 @@ public class ElasticsearchAssertions {
//1) whenever anything goes through a map while parsing, ordering is not preserved, which is perfectly ok //1) whenever anything goes through a map while parsing, ordering is not preserved, which is perfectly ok
//2) Jackson SMILE parser parses floats as double, which then get printed out as double (with double precision) //2) Jackson SMILE parser parses floats as double, which then get printed out as double (with double precision)
//Note that byte[] holding binary values need special treatment as they need to be properly compared item per item. //Note that byte[] holding binary values need special treatment as they need to be properly compared item per item.
Map<String, Object> actualMap = null;
Map<String, Object> expectedMap = null;
try (XContentParser actualParser = xContentType.xContent().createParser(NamedXContentRegistry.EMPTY, actual)) { try (XContentParser actualParser = xContentType.xContent().createParser(NamedXContentRegistry.EMPTY, actual)) {
Map<String, Object> actualMap = actualParser.map(); actualMap = actualParser.map();
try (XContentParser expectedParser = xContentType.xContent().createParser(NamedXContentRegistry.EMPTY, expected)) { try (XContentParser expectedParser = xContentType.xContent().createParser(NamedXContentRegistry.EMPTY, expected)) {
Map<String, Object> expectedMap = expectedParser.map(); expectedMap = expectedParser.map();
assertMapEquals(expectedMap, actualMap); try {
assertMapEquals(expectedMap, actualMap);
} catch (AssertionError error) {
NotEqualMessageBuilder message = new NotEqualMessageBuilder();
message.compareMaps(actualMap, expectedMap);
throw new AssertionError("Error when comparing xContent.\n" + message.toString(), error);
}
} }
} }
} }
@ -802,7 +811,6 @@ public class ElasticsearchAssertions {
/** /**
* Compares two maps recursively, using arrays comparisons for byte[] through Arrays.equals(byte[], byte[]) * Compares two maps recursively, using arrays comparisons for byte[] through Arrays.equals(byte[], byte[])
*/ */
@SuppressWarnings("unchecked")
private static void assertMapEquals(Map<String, Object> expected, Map<String, Object> actual) { private static void assertMapEquals(Map<String, Object> expected, Map<String, Object> actual) {
assertEquals(expected.size(), actual.size()); assertEquals(expected.size(), actual.size());
for (Map.Entry<String, Object> expectedEntry : expected.entrySet()) { for (Map.Entry<String, Object> expectedEntry : expected.entrySet()) {

159
test/framework/src/test/java/org/elasticsearch/test/hamcrest/ElasticsearchAssertionsTests.java
View File

@ -24,13 +24,20 @@ import org.elasticsearch.common.io.stream.NamedWriteableRegistry;
import org.elasticsearch.common.io.stream.StreamInput; import org.elasticsearch.common.io.stream.StreamInput;
import org.elasticsearch.common.io.stream.StreamOutput; import org.elasticsearch.common.io.stream.StreamOutput;
import org.elasticsearch.common.io.stream.Streamable; import org.elasticsearch.common.io.stream.Streamable;
import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.common.xcontent.XContentHelper;
import org.elasticsearch.common.xcontent.XContentParser;
import org.elasticsearch.common.xcontent.json.JsonXContent;
import org.elasticsearch.test.ESTestCase; import org.elasticsearch.test.ESTestCase;
import org.elasticsearch.test.RandomObjects;
import java.io.IOException; import java.io.IOException;
import static java.util.Collections.emptyList; import static java.util.Collections.emptyList;
import static org.elasticsearch.test.VersionUtils.randomVersion; import static org.elasticsearch.test.VersionUtils.randomVersion;
import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertToXContentEquivalent;
import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertVersionSerializable; import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertVersionSerializable;
import static org.hamcrest.Matchers.containsString;
public class ElasticsearchAssertionsTests extends ESTestCase { public class ElasticsearchAssertionsTests extends ESTestCase {
public void testAssertVersionSerializableIsOkWithIllegalArgumentException() { public void testAssertVersionSerializableIsOkWithIllegalArgumentException() {
@ -52,4 +59,156 @@ public class ElasticsearchAssertionsTests extends ESTestCase {
throw new IllegalArgumentException("Not supported."); throw new IllegalArgumentException("Not supported.");
} }
} }
public void testAssertXContentEquivalent() throws IOException {
try (XContentBuilder original = JsonXContent.contentBuilder()) {
original.startObject();
for (Object value : RandomObjects.randomStoredFieldValues(random(), original.contentType()).v1()) {
original.field(randomAlphaOfLength(10), value);
}
{
original.startObject(randomAlphaOfLength(10));
for (Object value : RandomObjects.randomStoredFieldValues(random(), original.contentType()).v1()) {
original.field(randomAlphaOfLength(10), value);
}
original.endObject();
}
{
original.startArray(randomAlphaOfLength(10));
for (Object value : RandomObjects.randomStoredFieldValues(random(), original.contentType()).v1()) {
original.value(value);
}
original.endArray();
}
original.endObject();
try (XContentBuilder copy = JsonXContent.contentBuilder();
XContentParser parser = createParser(original.contentType().xContent(), original.bytes())) {
parser.nextToken();
XContentHelper.copyCurrentStructure(copy.generator(), parser);
try (XContentBuilder copyShuffled = shuffleXContent(copy) ) {
assertToXContentEquivalent(original.bytes(), copyShuffled.bytes(), original.contentType());
}
}
}
}
public void testAssertXContentEquivalentErrors() throws IOException {
{
XContentBuilder builder = JsonXContent.contentBuilder();
builder.startObject();
{
builder.startObject("foo");
{
builder.field("f1", "value1");
builder.field("f2", "value2");
}
builder.endObject();
}
builder.endObject();
XContentBuilder otherBuilder = JsonXContent.contentBuilder();
otherBuilder.startObject();
{
otherBuilder.startObject("foo");
{
otherBuilder.field("f1", "value1");
}
otherBuilder.endObject();
}
otherBuilder.endObject();
AssertionError error = expectThrows(AssertionError.class,
() -> assertToXContentEquivalent(builder.bytes(), otherBuilder.bytes(), builder.contentType()));
assertThat(error.getMessage(), containsString("f2: expected [value2] but not found"));
}
{
XContentBuilder builder = JsonXContent.contentBuilder();
builder.startObject();
{
builder.startObject("foo");
{
builder.field("f1", "value1");
builder.field("f2", "value2");
}
builder.endObject();
}
builder.endObject();
XContentBuilder otherBuilder = JsonXContent.contentBuilder();
otherBuilder.startObject();
{
otherBuilder.startObject("foo");
{
otherBuilder.field("f1", "value1");
otherBuilder.field("f2", "differentValue2");
}
otherBuilder.endObject();
}
otherBuilder.endObject();
AssertionError error = expectThrows(AssertionError.class,
() -> assertToXContentEquivalent(builder.bytes(), otherBuilder.bytes(), builder.contentType()));
assertThat(error.getMessage(), containsString("f2: expected [value2] but was [differentValue2]"));
}
{
XContentBuilder builder = JsonXContent.contentBuilder();
builder.startObject();
{
builder.startArray("foo");
{
builder.value("one");
builder.value("two");
builder.value("three");
}
builder.endArray();
}
builder.field("f1", "value");
builder.endObject();
XContentBuilder otherBuilder = JsonXContent.contentBuilder();
otherBuilder.startObject();
{
otherBuilder.startArray("foo");
{
otherBuilder.value("one");
otherBuilder.value("two");
otherBuilder.value("four");
}
otherBuilder.endArray();
}
otherBuilder.field("f1", "value");
otherBuilder.endObject();
AssertionError error = expectThrows(AssertionError.class,
() -> assertToXContentEquivalent(builder.bytes(), otherBuilder.bytes(), builder.contentType()));
assertThat(error.getMessage(), containsString("2: expected [three] but was [four]"));
}
{
XContentBuilder builder = JsonXContent.contentBuilder();
builder.startObject();
{
builder.startArray("foo");
{
builder.value("one");
builder.value("two");
builder.value("three");
}
builder.endArray();
}
builder.endObject();
XContentBuilder otherBuilder = JsonXContent.contentBuilder();
otherBuilder.startObject();
{
otherBuilder.startArray("foo");
{
otherBuilder.value("one");
otherBuilder.value("two");
}
otherBuilder.endArray();
}
otherBuilder.endObject();
AssertionError error = expectThrows(AssertionError.class,
() -> assertToXContentEquivalent(builder.bytes(), otherBuilder.bytes(), builder.contentType()));
assertThat(error.getMessage(), containsString("expected [1] more entries"));
}
}
} }