honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ML-DataFrame] improve error message for timeout case in stop (#46131) 

improve error message if stopping of transform times out.

related #45610
This commit is contained in:
Hendrik Muhs 2019-09-06 08:35:24 +02:00
parent 78824cce81
commit ab5f09d29b
1 changed files with 49 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/action/TransportStopDataFrameTransformAction.java
View File

@ -253,7 +253,55 @@ public class TransportStopDataFrameTransformAction extends TransportTasksAction<
listener.onFailure(new ElasticsearchStatusException(message, RestStatus.CONFLICT)); listener.onFailure(new ElasticsearchStatusException(message, RestStatus.CONFLICT));
}, },
listener::onFailure e -> {
// waitForPersistentTasksCondition throws a IllegalStateException on timeout
if (e instanceof IllegalStateException && e.getMessage().startsWith("Timed out")) {
PersistentTasksCustomMetaData persistentTasksCustomMetaData = clusterService.state().metaData()
.custom(PersistentTasksCustomMetaData.TYPE);
if (persistentTasksCustomMetaData == null) {
listener.onResponse(new Response(Boolean.TRUE));
return;
}
// collect which tasks are still running
Set<String> stillRunningTasks = new HashSet<>();
for (String persistentTaskId : persistentTaskIds) {
if (persistentTasksCustomMetaData.getTask(persistentTaskId) != null) {
stillRunningTasks.add(persistentTaskId);
}
}
if (stillRunningTasks.isEmpty()) {
// should not happen
listener.onResponse(new Response(Boolean.TRUE));
return;
} else {
StringBuilder message = new StringBuilder();
if (persistentTaskIds.size() - stillRunningTasks.size() - exceptions.size() > 0) {
message.append("Successfully stopped [");
message.append(persistentTaskIds.size() - stillRunningTasks.size() - exceptions.size());
message.append("] transforms. ");
}
if (exceptions.size() > 0) {
message.append("Could not stop the transforms ");
message.append(exceptions.keySet());
message.append(" as they were failed. Use force stop to stop the transforms. ");
}
if (stillRunningTasks.size() > 0) {
message.append("Could not stop the transforms ");
message.append(stillRunningTasks);
message.append(" as they timed out.");
}
listener.onFailure(new ElasticsearchStatusException(message.toString(), RestStatus.REQUEST_TIMEOUT));
return;
}
}
listener.onFailure(e);
}
)); ));
} }
} }