From a45c05d907f29323c667111d8bda3d0a3e4b5d0f Mon Sep 17 00:00:00 2001 From: Simon Willnauer Date: Mon, 22 Jun 2015 09:40:06 +0200 Subject: [PATCH] Use abstract runnable in scheduled ping --- .../transport/netty/NettyTransport.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/org/elasticsearch/transport/netty/NettyTransport.java b/core/src/main/java/org/elasticsearch/transport/netty/NettyTransport.java index fc3f484bca7..520f54bda39 100644 --- a/core/src/main/java/org/elasticsearch/transport/netty/NettyTransport.java +++ b/core/src/main/java/org/elasticsearch/transport/netty/NettyTransport.java @@ -50,6 +50,7 @@ import org.elasticsearch.common.transport.TransportAddress; import org.elasticsearch.common.unit.ByteSizeValue; import org.elasticsearch.common.unit.TimeValue; import org.elasticsearch.common.util.BigArrays; +import org.elasticsearch.common.util.concurrent.AbstractRunnable; import org.elasticsearch.common.util.concurrent.EsExecutors; import org.elasticsearch.common.util.concurrent.KeyedLock; import org.elasticsearch.monitor.jvm.JvmInfo; @@ -1122,13 +1123,13 @@ public class NettyTransport extends AbstractLifecycleComponent implem } } - class ScheduledPing implements Runnable { + class ScheduledPing extends AbstractRunnable { final CounterMetric successfulPings = new CounterMetric(); final CounterMetric failedPings = new CounterMetric(); @Override - public void run() { + protected void doRun() throws Exception { if (lifecycle.stoppedOrClosed()) { return; } @@ -1156,5 +1157,14 @@ public class NettyTransport extends AbstractLifecycleComponent implem } threadPool.schedule(pingSchedule, ThreadPool.Names.GENERIC, this); } + + @Override + public void onFailure(Throwable t) { + if (lifecycle.stoppedOrClosed()) { + logger.trace("[{}] failed to send ping transport message", t); + } else { + logger.warn("[{}] failed to send ping transport message", t); + } + } } }