From b0b61ee0c37f6036d35e43cff049c3a629df6f8f Mon Sep 17 00:00:00 2001 From: Martijn van Groningen Date: Wed, 24 Dec 2014 11:47:12 +0100 Subject: [PATCH] Renamed allowNoIndices to failNoIndices and changed parameter order. --- .../java/org/elasticsearch/cluster/metadata/MetaData.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/elasticsearch/cluster/metadata/MetaData.java b/src/main/java/org/elasticsearch/cluster/metadata/MetaData.java index 5d351558c0d..e738cc866aa 100644 --- a/src/main/java/org/elasticsearch/cluster/metadata/MetaData.java +++ b/src/main/java/org/elasticsearch/cluster/metadata/MetaData.java @@ -679,7 +679,7 @@ public class MetaData implements Iterable { // optimize for single element index (common case) if (aliasesOrIndices.length == 1) { - return concreteIndices(aliasesOrIndices[0], indicesOptions.allowNoIndices(), indicesOptions); + return concreteIndices(aliasesOrIndices[0], indicesOptions, indicesOptions.allowNoIndices()); } // check if its a possible aliased index, if not, just return the passed array @@ -712,7 +712,7 @@ public class MetaData implements Iterable { Set actualIndices = new HashSet<>(); for (String aliasOrIndex : aliasesOrIndices) { - String[] indices = concreteIndices(aliasOrIndex, indicesOptions.ignoreUnavailable(), indicesOptions); + String[] indices = concreteIndices(aliasOrIndex, indicesOptions, indicesOptions.ignoreUnavailable()); Collections.addAll(actualIndices, indices); } @@ -742,7 +742,7 @@ public class MetaData implements Iterable { return indices[0]; } - private String[] concreteIndices(String aliasOrIndex, boolean allowNoIndices, IndicesOptions options) throws IndexMissingException, ElasticsearchIllegalArgumentException { + private String[] concreteIndices(String aliasOrIndex, IndicesOptions options, boolean failNoIndices) throws IndexMissingException, ElasticsearchIllegalArgumentException { boolean failClosed = options.forbidClosedIndices() && !options.ignoreUnavailable(); // a quick check, if this is an actual index, if so, return it @@ -760,7 +760,7 @@ public class MetaData implements Iterable { } // not an actual index, fetch from an alias String[] indices = aliasAndIndexToIndexMap.getOrDefault(aliasOrIndex, Strings.EMPTY_ARRAY); - if (indices.length == 0 && !allowNoIndices) { + if (indices.length == 0 && !failNoIndices) { throw new IndexMissingException(new Index(aliasOrIndex)); } if (indices.length > 1 && !options.allowAliasesToMultipleIndices()) {