honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve exception handling in HttpDownloadHelper

This commit is contained in:
Simon Willnauer 2014-03-14 21:11:22 +01:00
parent d670575d74
commit b622fd18a2
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/main/java/org/elasticsearch/common/http/client/HttpDownloadHelper.java
View File

@ -332,13 +332,14 @@ public class HttpDownloadHelper {
}
finished = !isInterrupted();
} finally {
IOUtils.close(os, is);
// we have started to (over)write dest, but failed.
// Try to delete the garbage we'd otherwise leave
// behind.
if (!finished) {
// we have started to (over)write dest, but failed.
// Try to delete the garbage we'd otherwise leave
// behind.
IOUtils.closeWhileHandlingException(os, is);
dest.delete();
} else {
IOUtils.close(os, is);
}
}
progress.endDownload();