honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improving test stability for CompletionTests 

Randomized testing caught an issue showing that the test should
flush after indexing a document, as always the same document is
indexed.
This commit is contained in:
Alexander Reelsen 2013-10-29 13:10:29 +01:00
parent 9e6fab3a6d
commit b6d2be7a51
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/test/java/org/elasticsearch/search/suggest/CompletionSuggestSearchTests.java
View File

@ -814,13 +814,13 @@ public class CompletionSuggestSearchTests extends AbstractIntegrationTest {
client().admin().indices().prepareCreate(INDEX).get(); client().admin().indices().prepareCreate(INDEX).get();
int iters = atLeast(10); int iters = atLeast(10);
for (int i = 0; i < iters; i++) { for (int i = 0; i < iters; i++) {
int len = between(3, 50); int maxInputLen = between(3, 50);
String str = replaceReservedChars(randomRealisticUnicodeOfCodepointLengthBetween(len + 1, atLeast(len + 2)), (char) 0x01); String str = replaceReservedChars(randomRealisticUnicodeOfCodepointLengthBetween(maxInputLen + 1, atLeast(maxInputLen + 2)), (char) 0x01);
ElasticsearchAssertions.assertAcked(client().admin().indices().preparePutMapping(INDEX).setType(TYPE).setSource(jsonBuilder().startObject() ElasticsearchAssertions.assertAcked(client().admin().indices().preparePutMapping(INDEX).setType(TYPE).setSource(jsonBuilder().startObject()
.startObject(TYPE).startObject("properties") .startObject(TYPE).startObject("properties")
.startObject(FIELD) .startObject(FIELD)
.field("type", "completion") .field("type", "completion")
.field("max_input_len", len) .field("max_input_len", maxInputLen)
// upgrade mapping each time // upgrade mapping each time
.field("analyzer", "keyword") .field("analyzer", "keyword")
.endObject() .endObject()
@ -833,11 +833,16 @@ public class CompletionSuggestSearchTests extends AbstractIntegrationTest {
.field("output", "foobar") .field("output", "foobar")
.endObject().endObject() .endObject().endObject()
).setRefresh(true).get(); ).setRefresh(true).get();
int prefixLen = CompletionFieldMapper.correctSubStringLen(str, between(1, len - 1)); // need to flush and refresh, because we keep changing the same document
// we have to make sure that segments without any live documents are deleted
flushAndRefresh();
int prefixLen = CompletionFieldMapper.correctSubStringLen(str, between(1, maxInputLen - 1));
assertSuggestions(str.substring(0, prefixLen), "foobar"); assertSuggestions(str.substring(0, prefixLen), "foobar");
if (len + 1 < str.length()) { if (maxInputLen + 1 < str.length()) {
assertSuggestions(str.substring(0, CompletionFieldMapper.correctSubStringLen(str, int offset = Character.isHighSurrogate(str.charAt(maxInputLen - 1)) ? 2 : 1;
len + (Character.isHighSurrogate(str.charAt(len - 1)) ? 2 : 1)))); int correctSubStringLen = CompletionFieldMapper.correctSubStringLen(str, maxInputLen + offset);
String shortenedSuggestion = str.substring(0, correctSubStringLen);
assertSuggestions(shortenedSuggestion);
} }
} }
} }