honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove the AbstracLifecycleComponent constructor with Settings (#37523) 

Adding the migration guide and removing the deprecated in 6.x
constructor

relates #35560
relates #34488
This commit is contained in:
Przemyslaw Gomulka 2019-01-17 09:10:09 +01:00 committed by GitHub
parent 18a3e48a4a
commit b6e5ccaf8a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/reference/migration/migrate_7_0/java.asciidoc
View File

@ -39,3 +39,9 @@ because `Settings` is no longer needed.
The client method `termVector`, deprecated in 2.0, has been removed. The method The client method `termVector`, deprecated in 2.0, has been removed. The method
`termVectors` (plural) should be used instead. `termVectors` (plural) should be used instead.
[float]
==== Deprecated constructor `AbstractLifecycleComponent(Settings settings)` removed
The constructor `AbstractLifecycleComponent(Settings settings)`, deprecated in 6.7
has been removed. The parameterless constructor should be used instead.

6
server/src/main/java/org/elasticsearch/common/component/AbstractLifecycleComponent.java
View File

@ -21,7 +21,6 @@ package org.elasticsearch.common.component;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.Logger;
import org.elasticsearch.common.settings.Settings;
import java.io.IOException; import java.io.IOException;
import java.util.List; import java.util.List;
@ -36,11 +35,6 @@ public abstract class AbstractLifecycleComponent implements LifecycleComponent {
protected AbstractLifecycleComponent() {} protected AbstractLifecycleComponent() {}
@Deprecated
protected AbstractLifecycleComponent(Settings settings) {
// TODO drop settings from ctor
}
@Override @Override
public Lifecycle.State lifecycleState() { public Lifecycle.State lifecycleState() {
return this.lifecycle.state(); return this.lifecycle.state();