From b8a96d9a6535c06cf9811bd031fc5385f0b5ca4c Mon Sep 17 00:00:00 2001 From: Colin Goodheart-Smithe Date: Tue, 22 Mar 2016 14:39:16 +0000 Subject: [PATCH] added breaking changes for the Java API to the breaking changes doc for 5.0 --- .../migration/migrate_5_0/java.asciidoc | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/docs/reference/migration/migrate_5_0/java.asciidoc b/docs/reference/migration/migrate_5_0/java.asciidoc index dc60ab58391..9c23cb7bd36 100644 --- a/docs/reference/migration/migrate_5_0/java.asciidoc +++ b/docs/reference/migration/migrate_5_0/java.asciidoc @@ -225,3 +225,40 @@ The `addSuggestion` method now required the user specified suggestion name, prev ===== SuggestionBuilder The `field` setter has been deleted. Instead the field name needs to be specified as constructor argument. + +==== SearchSourceBuilder + +All methods which take an `XContentBuilder`, `BytesReference` `Map` or `bytes[]` have been removed in favor of providing the +relevant builder object for that feature. This means that all search requests can now be validated at call time which results in much clearer +errors. + +The `defaultResourceWindowSize(int)` method has been removed. The window size should be set explicitly on all RescoreBuilder objects. + +==== SearchRequestBuilder + +All methods which take an `XContentBuilder`, `BytesReference` `Map` or `bytes[]` have been removed in favor of providing the +relevant builder object for that feature. This means that all search requests can now be validated at call time which results in much clearer +errors. + +All highlighter methods have been removed in favor of a single `highlighter(HighlightBuilder)` method. + +The `setExtraSource(SearchSourceBuilder)` method has been removed. + +The `setTemplateSource(String)` and `setTemplateSource(BytesReference)` methods have been removed. Use `setTemplate(Template)` instead. + +`setRescorer(Rescorer)` and `setRescorer(Rescorer, int)` have been removed infavor of `setRescorer(RescoreBuilder)` and `setRescorer(RescoreBuilder, int)` + +==== SearchRequest + +All template methods have been removed in favor of a single `template(Template)` method. + +All source methods have been removed in favor of a single `source(SearchSourceBuilder)` method. This means that all search requests can now be validated at call time which results in much clearer +errors. + +All extraSource methods have been removed. + +==== AggregationBuilder + +All method which take an `XContentBuilder`, `BytesReference` `Map` or `bytes[]` have been removed in favor of providing the +relevant builder object for that feature. This means that all requests can now be validated at call time which results in much clearer +errors.