honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[TEST] NettyTransportMultiPortIntegrationTests used wrong random to 

initialize ports.

JUnit uses an instance per test which caused the prot range to be
initialized twice since suite level tests are not configured in a
different context.
This commit is contained in:
Simon Willnauer 2014-10-26 11:28:29 +01:00
parent 58c292dc14
commit bb7ad4ab96
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/test/java/org/elasticsearch/test/transport/NettyTransportMultiPortIntegrationTests.java
View File

@ -18,6 +18,7 @@
*/ */
package org.elasticsearch.test.transport; package org.elasticsearch.test.transport;
import org.apache.lucene.util.LuceneTestCase;
import org.elasticsearch.action.admin.cluster.health.ClusterHealthResponse; import org.elasticsearch.action.admin.cluster.health.ClusterHealthResponse;
import org.elasticsearch.action.admin.cluster.health.ClusterHealthStatus; import org.elasticsearch.action.admin.cluster.health.ClusterHealthStatus;
import org.elasticsearch.client.transport.TransportClient; import org.elasticsearch.client.transport.TransportClient;
@ -43,11 +44,15 @@ import static org.hamcrest.Matchers.is;
@ClusterScope(scope = Scope.SUITE, numDataNodes = 1, enableRandomBenchNodes = false) @ClusterScope(scope = Scope.SUITE, numDataNodes = 1, enableRandomBenchNodes = false)
public class NettyTransportMultiPortIntegrationTests extends ElasticsearchIntegrationTest { public class NettyTransportMultiPortIntegrationTests extends ElasticsearchIntegrationTest {
private final int randomPort = randomIntBetween(1025, 65000); private static int randomPort = -1;
private final String randomPortRange = String.format(Locale.ROOT, "%s-%s", randomPort, randomPort+10); private static String randomPortRange;
@Override @Override
protected Settings nodeSettings(int nodeOrdinal) { protected Settings nodeSettings(int nodeOrdinal) {
if (randomPort == -1) {
randomPort = randomIntBetween(1025, 65000);
randomPortRange = String.format(Locale.ROOT, "%s-%s", randomPort, randomPort+10);
}
return settingsBuilder() return settingsBuilder()
.put(super.nodeSettings(nodeOrdinal)) .put(super.nodeSettings(nodeOrdinal))
.put("network.host", "127.0.0.1") .put("network.host", "127.0.0.1")