From bbb61002bae8e7901ddac092935b8fcfaea44ccd Mon Sep 17 00:00:00 2001
From: Jason Tedor <jason@tedor.me>
Date: Mon, 18 Feb 2019 15:01:44 -0500
Subject: [PATCH] Add some logging related to retention lease syncing (#39066)
When the background retention lease sync fires, we check an see if any
retention leases are expired. If any did expire, we execute a full
retention lease sync (write action). Since this is happening on a
background thread, we do not block that thread waiting for success (it
will simply try again when the timer elapses). However, we were
swallowing exceptions that indicate failure. This commit addresses that
by logging the failures. Additionally, we add some trace logging to the
execution of syncing retention leases.
---
.../java/org/elasticsearch/index/shard/IndexShard.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/server/src/main/java/org/elasticsearch/index/shard/IndexShard.java b/server/src/main/java/org/elasticsearch/index/shard/IndexShard.java
index 50400c69617..4bdad8d5ec3 100644
--- a/server/src/main/java/org/elasticsearch/index/shard/IndexShard.java
+++ b/server/src/main/java/org/elasticsearch/index/shard/IndexShard.java
@@ -2011,8 +2011,13 @@ public class IndexShard extends AbstractIndexShardComponent implements IndicesCl
verifyNotClosed();
final Tuple<Boolean, RetentionLeases> retentionLeases = getRetentionLeases(true);
if (retentionLeases.v1()) {
- retentionLeaseSyncer.sync(shardId, retentionLeases.v2(), ActionListener.wrap(() -> {}));
+ logger.trace("syncing retention leases [{}] after expiration check", retentionLeases.v2());
+ retentionLeaseSyncer.sync(
+ shardId,
+ retentionLeases.v2(),
+ ActionListener.wrap(r -> {}, e -> logger.warn("failed to sync retention leases after expiration check", e)));
} else {
+ logger.trace("background syncing retention leases [{}] after expiration check", retentionLeases.v2());
retentionLeaseSyncer.backgroundSync(shardId, retentionLeases.v2());
}
}