From bc5be696e4e7211757ee3fd15139fdce026f4646 Mon Sep 17 00:00:00 2001
From: Alexander Reelsen <alexander@reelsen.net>
Date: Mon, 10 Jul 2017 09:20:16 +0200
Subject: [PATCH] Monitoring: Fix cluster monitoring watches to prevent
 compilations (elastic/x-pack-elasticsearch#1944)

The monitoring watches are roughly executing the same queries even when
they run against different clusters. However the way they were created,
where the cluster name is replaced via search & replace instead of using
watch metadata implies, that every watch is different from a script
compilation cache perspective. On top of that every of those watches is
executed once a minute. So if a new node becomes master and you monitor
three clusters, this results in a fair share of compilations in the first minute. The
reason for the compilation is the fact, that the search input uses
mustache for being able to add dynamic parts into a search using
mustache.

Several of those watches also need to compile more than one search
request.

The maximum default value for script compilations is only 15 and thus at
least one watch will not be executed due to failing script compilations.

This commit changes the four watches, so that the search requests are
cacheable. This means, no matter how many clusters you monitor, there
will be only needed four compilations for the different watches and
that's it.

Relates elastic/support-dev-help#2090

Original commit: elastic/x-pack-elasticsearch@6c877421bbefcdf33d1ecf82acba05de00a1f96a
---
 .../monitoring/watches/elasticsearch_cluster_status.json      | 4 ++--
 .../monitoring/watches/elasticsearch_version_mismatch.json    | 4 ++--
 .../resources/monitoring/watches/kibana_version_mismatch.json | 4 ++--
 .../monitoring/watches/logstash_version_mismatch.json         | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/plugin/src/main/resources/monitoring/watches/elasticsearch_cluster_status.json b/plugin/src/main/resources/monitoring/watches/elasticsearch_cluster_status.json
index d7b362ff8f7..128de820f6f 100644
--- a/plugin/src/main/resources/monitoring/watches/elasticsearch_cluster_status.json
+++ b/plugin/src/main/resources/monitoring/watches/elasticsearch_cluster_status.json
@@ -43,7 +43,7 @@
                       "filter": [
                         {
                           "term": {
-                            "cluster_uuid": "${monitoring.watch.cluster_uuid}"
+                            "cluster_uuid": "{{ctx.metadata.cluster_uuid}}"
                           }
                         },
                         {
@@ -85,7 +85,7 @@
                     "bool": {
                       "filter": {
                         "term": {
-                          "_id": "${monitoring.watch.unique_id}"
+                          "_id": "{{ctx.watch_id}}"
                         }
                       }
                     }
diff --git a/plugin/src/main/resources/monitoring/watches/elasticsearch_version_mismatch.json b/plugin/src/main/resources/monitoring/watches/elasticsearch_version_mismatch.json
index 0991999476c..364b776f382 100644
--- a/plugin/src/main/resources/monitoring/watches/elasticsearch_version_mismatch.json
+++ b/plugin/src/main/resources/monitoring/watches/elasticsearch_version_mismatch.json
@@ -36,7 +36,7 @@
                       "filter": [
                         {
                           "term": {
-                            "_id": "${monitoring.watch.cluster_uuid}"
+                            "_id": "{{ctx.metadata.cluster_uuid}}"
                           }
                         },
                         {
@@ -81,7 +81,7 @@
                     "bool": {
                       "filter": {
                         "term": {
-                          "_id": "${monitoring.watch.unique_id}"
+                          "_id": "{{ctx.watch_id}}"
                         }
                       }
                     }
diff --git a/plugin/src/main/resources/monitoring/watches/kibana_version_mismatch.json b/plugin/src/main/resources/monitoring/watches/kibana_version_mismatch.json
index 4f0d036f538..89a06496465 100644
--- a/plugin/src/main/resources/monitoring/watches/kibana_version_mismatch.json
+++ b/plugin/src/main/resources/monitoring/watches/kibana_version_mismatch.json
@@ -33,7 +33,7 @@
                       "filter": [
                         {
                           "term": {
-                            "cluster_uuid": "${monitoring.watch.cluster_uuid}"
+                            "cluster_uuid": "{{ctx.metadata.cluster_uuid}}"
                           }
                         },
                         {
@@ -108,7 +108,7 @@
                     "bool": {
                       "filter": {
                         "term": {
-                          "_id": "${monitoring.watch.unique_id}"
+                          "_id": "{{ctx.watch_id}}"
                         }
                       }
                     }
diff --git a/plugin/src/main/resources/monitoring/watches/logstash_version_mismatch.json b/plugin/src/main/resources/monitoring/watches/logstash_version_mismatch.json
index cd1007339b0..4f2d3562a32 100644
--- a/plugin/src/main/resources/monitoring/watches/logstash_version_mismatch.json
+++ b/plugin/src/main/resources/monitoring/watches/logstash_version_mismatch.json
@@ -33,7 +33,7 @@
                       "filter": [
                         {
                           "term": {
-                            "cluster_uuid": "${monitoring.watch.cluster_uuid}"
+                            "cluster_uuid": "{{ctx.metadata.cluster_uuid}}"
                           }
                         },
                         {
@@ -108,7 +108,7 @@
                     "bool": {
                       "filter": {
                         "term": {
-                          "_id": "${monitoring.watch.unique_id}"
+                          "_id": "{{ctx.watch_id}}"
                         }
                       }
                     }