Enable Checkstyle RedundantModifier

Original commit: elastic/x-pack-elasticsearch@7455e88dce
This commit is contained in:
Tanguy Leroux 2016-07-04 09:51:28 +02:00
parent 1cd53c41e2
commit bd0cf521aa
5 changed files with 7 additions and 12 deletions

View File

@ -420,7 +420,7 @@ public class TransportGraphExploreAction extends HandledTransportAction<GraphExp
// weakest weights. // weakest weights.
// A priority queue is used to trim vertices according to the size settings // A priority queue is used to trim vertices according to the size settings
// requested for each field. // requested for each field.
private final void trimNewAdditions(Hop currentHop, ArrayList<Connection> newConnections, ArrayList<Vertex> newVertices) { private void trimNewAdditions(Hop currentHop, ArrayList<Connection> newConnections, ArrayList<Vertex> newVertices) {
Set<Vertex> evictions = new HashSet<>(); Set<Vertex> evictions = new HashSet<>();
for (int k = 0; k < currentHop.getNumberVertexRequests(); k++) { for (int k = 0; k < currentHop.getNumberVertexRequests(); k++) {
@ -460,7 +460,7 @@ public class TransportGraphExploreAction extends HandledTransportAction<GraphExp
// we can do something server-side here // we can do something server-side here
// Helper method - compute the total signal of all scores in the search results // Helper method - compute the total signal of all scores in the search results
private final double getExpandTotalSignalStrength(Hop lastHop, Hop currentHop, Sampler sample) { private double getExpandTotalSignalStrength(Hop lastHop, Hop currentHop, Sampler sample) {
double totalSignalOutput = 0; double totalSignalOutput = 0;
for (int j = 0; j < lastHop.getNumberVertexRequests(); j++) { for (int j = 0; j < lastHop.getNumberVertexRequests(); j++) {
VertexRequest lastVr = lastHop.getVertexRequest(j); VertexRequest lastVr = lastHop.getVertexRequest(j);
@ -688,7 +688,7 @@ public class TransportGraphExploreAction extends HandledTransportAction<GraphExp
} }
// Helper method - Provides a total signal strength for all terms connected to the initial query // Helper method - Provides a total signal strength for all terms connected to the initial query
private final double getInitialTotalSignalStrength(Hop rootHop, Sampler sample) { private double getInitialTotalSignalStrength(Hop rootHop, Sampler sample) {
double totalSignalStrength = 0; double totalSignalStrength = 0;
for (int i = 0; i < rootHop.getNumberVertexRequests(); i++) { for (int i = 0; i < rootHop.getNumberVertexRequests(); i++) {
if (request.useSignificance()) { if (request.useSignificance()) {

View File

@ -65,7 +65,7 @@ public class LdapSession implements Closeable {
return groupsResolver.resolve(ldap, userDn, timeout, logger); return groupsResolver.resolve(ldap, userDn, timeout, logger);
} }
public static interface GroupsResolver { public interface GroupsResolver {
List<String> resolve(LDAPInterface ldapConnection, String userDn, TimeValue timeout, ESLogger logger); List<String> resolve(LDAPInterface ldapConnection, String userDn, TimeValue timeout, ESLogger logger);

View File

@ -484,7 +484,7 @@ public class BCrypt {
* @param lr an array containing the two 32-bit half blocks * @param lr an array containing the two 32-bit half blocks
* @param off the position in the array of the blocks * @param off the position in the array of the blocks
*/ */
private final void encipher(int lr[], int off) { private void encipher(int lr[], int off) {
int i, n, l = lr[off], r = lr[off + 1]; int i, n, l = lr[off], r = lr[off + 1];
l ^= P[0]; l ^= P[0];

View File

@ -10,12 +10,7 @@ package org.elasticsearch.xpack.security.authc.support;
*/ */
public interface RefreshListener { public interface RefreshListener {
static final RefreshListener NOOP = new RefreshListener() { RefreshListener NOOP = () -> {};
@Override
public void onRefresh() {
}
};
void onRefresh(); void onRefresh();
} }

View File

@ -29,7 +29,7 @@ public final class SearchRequestEquivalence {
private SearchRequestEquivalence() { private SearchRequestEquivalence() {
} }
public final boolean equivalent(@Nullable SearchRequest a, @Nullable SearchRequest b) { public boolean equivalent(@Nullable SearchRequest a, @Nullable SearchRequest b) {
return a == b ? true : (a != null && b != null ? this.doEquivalent(a, b) : false); return a == b ? true : (a != null && b != null ? this.doEquivalent(a, b) : false);
} }