honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

More complete exception message in settings tests 

This commit adds additional details to the exception message assertions
in the YAML settings loader tests.
This commit is contained in:
Jason Tedor 2016-06-03 16:18:46 -04:00
parent 974c753bf6
commit be0036542c
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
core/src/test/java/org/elasticsearch/common/settings/loader/YamlSettingsLoaderTests.java
View File

@ -19,17 +19,16 @@
package org.elasticsearch.common.settings.loader;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Collections;
import org.elasticsearch.ElasticsearchParseException;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.common.settings.SettingsException;
import org.elasticsearch.test.ESTestCase;
import static org.hamcrest.Matchers.containsString;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Collections;
import static org.hamcrest.Matchers.equalTo;
public class YamlSettingsLoaderTests extends ESTestCase {
@ -75,8 +74,10 @@ public class YamlSettingsLoaderTests extends ESTestCase {
});
assertEquals(e.getCause().getClass(), ElasticsearchParseException.class);
String msg = e.getCause().getMessage();
assertTrue(msg, msg.contains("duplicate settings key [foo] found"));
assertTrue(msg, msg.contains("previous value [bar], current value [baz]"));
assertTrue(
msg,
msg.contains("duplicate settings key [foo] found at line number [2], column number [6], " +
"previous value [bar], current value [baz]"));
}
public void testMissingValue() throws Exception {
@ -85,6 +86,8 @@ public class YamlSettingsLoaderTests extends ESTestCase {
ElasticsearchParseException e = expectThrows(ElasticsearchParseException.class, () -> {
Settings.builder().loadFromPath(tmp);
});
assertTrue(e.getMessage(), e.getMessage().contains("null-valued setting found for key [foo] found at line"));
assertTrue(
e.getMessage(),
e.getMessage().contains("null-valued setting found for key [foo] found at line number [1], column number [5]"));
}
}