Remove BWC repository test (#30500)

This commit removes a test that we can not restore from 1.x and 2.x
repository files. This test is not needed, the version of Elasticsearch
that this commit targets can not even read index files from those
versions.

server/src/test/java/org/elasticsearch/bwcompat/RestoreBackwardsCompatIT.java

@@ -1,114 +0,0 @@
-/*
- * Licensed to Elasticsearch under one or more contributor
- * license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright
- * ownership. Elasticsearch licenses this file to you under
- * the Apache License, Version 2.0 (the "License"); you may
- * not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.elasticsearch.bwcompat;
-
-import org.elasticsearch.common.io.FileTestUtils;
-import org.elasticsearch.common.settings.Settings;
-import org.elasticsearch.env.Environment;
-import org.elasticsearch.repositories.fs.FsRepository;
-import org.elasticsearch.snapshots.AbstractSnapshotIntegTestCase;
-import org.elasticsearch.snapshots.SnapshotRestoreException;
-import org.elasticsearch.snapshots.mockstore.MockRepository;
-import org.elasticsearch.test.ESIntegTestCase.ClusterScope;
-import org.elasticsearch.test.ESIntegTestCase.Scope;
-import org.junit.BeforeClass;
-
-import java.io.IOException;
-import java.nio.file.DirectoryStream;
-import java.nio.file.Files;
-import java.nio.file.Path;
-import java.util.ArrayList;
-import java.util.List;
-
-import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertAcked;
-import static org.hamcrest.Matchers.containsString;
-import static org.hamcrest.Matchers.greaterThan;
-
-/**
- * Tests that restoring from a very old snapshot fails appropriately.
- */
-@ClusterScope(scope = Scope.TEST)
-public class RestoreBackwardsCompatIT extends AbstractSnapshotIntegTestCase {
-
-    private static Path repoPath;
-
-    @Override
-    protected Settings nodeSettings(int nodeOrdinal) {
-        return Settings.builder()
-            .put(super.nodeSettings(nodeOrdinal))
-            .put(Environment.PATH_REPO_SETTING.getKey(), repoPath)
-            .build();
-    }
-
-    @BeforeClass
-    public static void repoSetup() throws IOException {
-        repoPath = createTempDir("repositories");
-    }
-
-    public void testRestoreUnsupportedSnapshots() throws Exception {
-        String repo = "test_repo";
-        String snapshot = "test_1";
-        List<String> repoVersions = unsupportedRepoVersions();
-        assertThat(repoVersions.size(), greaterThan(0));
-        for (String version : repoVersions) {
-            createRepo("unsupportedrepo", version, repo);
-            assertUnsupportedIndexFailsToRestore(repo, snapshot);
-        }
-    }
-
-    private List<String> unsupportedRepoVersions() throws Exception {
-        return listRepoVersions("unsupportedrepo");
-    }
-
-    private List<String> listRepoVersions(String prefix) throws Exception {
-        List<String> repoVersions = new ArrayList<>();
-        Path repoFiles = getBwcIndicesPath();
-        try (DirectoryStream<Path> stream = Files.newDirectoryStream(repoFiles, prefix + "-*.zip")) {
-            for (Path entry : stream) {
-                String fileName = entry.getFileName().toString();
-                String version = fileName.substring(prefix.length() + 1);
-                version = version.substring(0, version.length() - ".zip".length());
-                repoVersions.add(version);
-            }
-        }
-        return repoVersions;
-    }
-
-    private void createRepo(String prefix, String version, String repo) throws Exception {
-        Path repoFileFromBuild = getBwcIndicesPath().resolve(prefix + "-" + version + ".zip");
-        String repoFileName = repoFileFromBuild.getFileName().toString().split(".zip")[0];
-        Path fsRepoPath = repoPath.resolve(repoFileName);
-        FileTestUtils.unzip(repoFileFromBuild, fsRepoPath, null);
-        logger.info("-->  creating repository [{}] for version [{}]", repo, version);
-        assertAcked(client().admin().cluster().preparePutRepository(repo)
-            .setType(MockRepository.TYPE).setSettings(Settings.builder()
-                .put(FsRepository.REPOSITORIES_LOCATION_SETTING.getKey(), fsRepoPath.getParent().relativize(fsRepoPath).resolve("repo").toString())));
-    }
-
-    private void assertUnsupportedIndexFailsToRestore(String repo, String snapshot) throws IOException {
-        logger.info("--> restoring unsupported snapshot");
-        try {
-            client().admin().cluster().prepareRestoreSnapshot(repo, snapshot).setRestoreGlobalState(true).setWaitForCompletion(true).get();
-            fail("should have failed to restore - " + repo);
-        } catch (SnapshotRestoreException ex) {
-            assertThat(ex.getMessage(), containsString("snapshot does not exist"));
-        }
-    }
-}
-

test/framework/src/main/java/org/elasticsearch/common/io/FileTestUtils.java

@@ -1,97 +0,0 @@
-/*
- * Licensed to Elasticsearch under one or more contributor
- * license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright
- * ownership. Elasticsearch licenses this file to you under
- * the Apache License, Version 2.0 (the "License"); you may
- * not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.elasticsearch.common.io;
-
-import org.elasticsearch.common.Nullable;
-import org.junit.Assert;
-
-import java.io.IOException;
-import java.nio.file.Files;
-import java.nio.file.Path;
-import java.nio.file.Paths;
-import java.util.zip.ZipEntry;
-import java.util.zip.ZipInputStream;
-
-import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertFileExists;
-import static org.hamcrest.CoreMatchers.equalTo;
-import static org.hamcrest.CoreMatchers.is;
-
-/** test helper methods for working with files */
-public class FileTestUtils {
-
-    /**
-     * Check that a file contains a given String
-     * @param dir root dir for file
-     * @param filename relative path from root dir to file
-     * @param expected expected content (if null, we don't expect any file)
-     */
-    public static void assertFileContent(Path dir, String filename, String expected) throws IOException {
-        Assert.assertThat(Files.exists(dir), is(true));
-        Path file = dir.resolve(filename);
-        if (expected == null) {
-            Assert.assertThat("file [" + file + "] should not exist.", Files.exists(file), is(false));
-        } else {
-            assertFileExists(file);
-            String fileContent = new String(Files.readAllBytes(file), java.nio.charset.StandardCharsets.UTF_8);
-            // trim the string content to prevent different handling on windows vs. unix and CR chars...
-            Assert.assertThat(fileContent.trim(), equalTo(expected.trim()));
-        }
-    }
-
-    /**
-     * Unzip a zip file to a destination directory.  If the zip file does not exist, an IOException is thrown.
-     * If the destination directory does not exist, it will be created.
-     *
-     * @param zip      zip file to unzip
-     * @param destDir  directory to unzip the file to
-     * @param prefixToRemove  the (optional) prefix in the zip file path to remove when writing to the destination directory
-     * @throws IOException if zip file does not exist, or there was an error reading from the zip file or
-     *                     writing to the destination directory
-     */
-    public static void unzip(final Path zip, final Path destDir, @Nullable final String prefixToRemove) throws IOException {
-        if (Files.notExists(zip)) {
-            throw new IOException("[" + zip + "] zip file must exist");
-        }
-        Files.createDirectories(destDir);
-
-        try (ZipInputStream zipInput = new ZipInputStream(Files.newInputStream(zip))) {
-            ZipEntry entry;
-            while ((entry = zipInput.getNextEntry()) != null) {
-                final String entryPath;
-                if (prefixToRemove != null) {
-                    if (entry.getName().startsWith(prefixToRemove)) {
-                        entryPath = entry.getName().substring(prefixToRemove.length());
-                    } else {
-                        throw new IOException("prefix not found: " + prefixToRemove);
-                    }
-                } else {
-                    entryPath = entry.getName();
-                }
-                final Path path = Paths.get(destDir.toString(), entryPath);
-                if (entry.isDirectory()) {
-                    Files.createDirectories(path);
-                } else {
-                    Files.copy(zipInput, path);
-                }
-                zipInput.closeEntry();
-            }
-        }
-    }
-}