honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-23 13:26:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure replication response/requests implement writeable (#44392) (#44446)

Browse Source 
This commit cleans up replication response and request so that the base
class does not allow subclasses to implement Streamable.

relates #34389
This commit is contained in:
Ryan Ernst 2019-07-16 12:53:08 -07:00 committed by GitHub
parent 901310a826
commit c26edb4c43
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
13 changed files with 2 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server/src/main/java/org/elasticsearch/action/admin/indices/close/TransportVerifyShardBeforeCloseAction.java
View File

@ -171,11 +171,6 @@ public class TransportVerifyShardBeforeCloseAction extends TransportReplicationA
return "verify shard " + shardId + " before close with block " + clusterBlock;
}
@Override
public void readFrom(final StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(final StreamOutput out) throws IOException {
super.writeTo(out);

5
server/src/main/java/org/elasticsearch/action/admin/indices/flush/ShardFlushRequest.java
View File

@ -46,11 +46,6 @@ public class ShardFlushRequest extends ReplicationRequest<ShardFlushRequest> {
return request;
}
@Override
public void readFrom(StreamInput in) throws IOException {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(StreamOutput out) throws IOException {
super.writeTo(out);

5
server/src/main/java/org/elasticsearch/action/bulk/BulkShardRequest.java
View File

@ -84,11 +84,6 @@ public class BulkShardRequest extends ReplicatedWriteRequest<BulkShardRequest> {
}
}
@Override
public void readFrom(StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public String toString() {
// This is included in error messages so we'll try to make it somewhat user friendly.

5
server/src/main/java/org/elasticsearch/action/delete/DeleteRequest.java
View File

@ -298,11 +298,6 @@ public class DeleteRequest extends ReplicatedWriteRequest<DeleteRequest>
return OpType.DELETE;
}
@Override
public void readFrom(StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(StreamOutput out) throws IOException {
super.writeTo(out);

5
server/src/main/java/org/elasticsearch/action/index/IndexRequest.java
View File

@ -630,11 +630,6 @@ public class IndexRequest extends ReplicatedWriteRequest<IndexRequest> implement
routing(metaData.resolveWriteIndexRouting(routing, index));
}
@Override
public void readFrom(StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(StreamOutput out) throws IOException {
super.writeTo(out);

5
server/src/main/java/org/elasticsearch/action/resync/ResyncReplicationRequest.java
View File

@ -84,11 +84,6 @@ public final class ResyncReplicationRequest extends ReplicatedWriteRequest<Resyn
return operations;
}
@Override
public void readFrom(final StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(final StreamOutput out) throws IOException {
super.writeTo(out);

5
server/src/main/java/org/elasticsearch/action/support/replication/ReplicatedWriteRequest.java
View File

@ -61,11 +61,6 @@ public abstract class ReplicatedWriteRequest<R extends ReplicatedWriteRequest<R>
return refreshPolicy;
}
@Override
public void readFrom(StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(StreamOutput out) throws IOException {
super.writeTo(out);

2
server/src/main/java/org/elasticsearch/action/support/replication/ReplicationRequest.java
View File

@ -188,7 +188,7 @@ public abstract class ReplicationRequest<Request extends ReplicationRequest<Requ
}
@Override
public void readFrom(StreamInput in) throws IOException {
public final void readFrom(StreamInput in) throws IOException {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}

2
server/src/main/java/org/elasticsearch/action/support/replication/ReplicationResponse.java
View File

@ -58,7 +58,7 @@ public class ReplicationResponse extends ActionResponse {
}
@Override
public void readFrom(StreamInput in) throws IOException {
public final void readFrom(StreamInput in) throws IOException {
throw new UnsupportedOperationException("Streamable no longer used");
}

5
server/src/main/java/org/elasticsearch/index/seqno/RetentionLeaseBackgroundSyncAction.java
View File

@ -167,11 +167,6 @@ public class RetentionLeaseBackgroundSyncAction extends TransportReplicationActi
waitForActiveShards(ActiveShardCount.NONE);
}
@Override
public void readFrom(final StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(final StreamOutput out) throws IOException {
super.writeTo(Objects.requireNonNull(out));

5
server/src/main/java/org/elasticsearch/index/seqno/RetentionLeaseSyncAction.java
View File

@ -169,11 +169,6 @@ public class RetentionLeaseSyncAction extends
waitForActiveShards(ActiveShardCount.NONE);
}
@Override
public void readFrom(final StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(final StreamOutput out) throws IOException {
super.writeTo(Objects.requireNonNull(out));

5
server/src/test/java/org/elasticsearch/action/support/replication/TransportReplicationActionTests.java
View File

@ -1210,11 +1210,6 @@ public class TransportReplicationActionTests extends ESTestCase {
super.writeTo(out);
}
@Override
public void readFrom(StreamInput in) throws IOException {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void onRetry() {
super.onRetry();

5
x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/bulk/BulkShardOperationsRequest.java
View File

@ -50,11 +50,6 @@ public final class BulkShardOperationsRequest extends ReplicatedWriteRequest<Bul
return maxSeqNoOfUpdatesOrDeletes;
}
@Override
public void readFrom(final StreamInput in) {
throw new UnsupportedOperationException("usage of Streamable is to be replaced by Writeable");
}
@Override
public void writeTo(final StreamOutput out) throws IOException {
super.writeTo(out);