From c27237be9fc70b077164e22705a17d25ac1e5d9f Mon Sep 17 00:00:00 2001 From: Jason Tedor Date: Fri, 22 Jul 2016 13:30:05 -0400 Subject: [PATCH] Revert "Allow to listen on virtual interfaces" This reverts commit 4cb8b620c37decb69f31c92d08de765db1ec828e. --- .../common/network/NetworkUtils.java | 9 +-------- .../common/network/NetworkUtilsTests.java | 17 ----------------- 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/core/src/main/java/org/elasticsearch/common/network/NetworkUtils.java b/core/src/main/java/org/elasticsearch/common/network/NetworkUtils.java index e15073e25ce..8652d4c5c05 100644 --- a/core/src/main/java/org/elasticsearch/common/network/NetworkUtils.java +++ b/core/src/main/java/org/elasticsearch/common/network/NetworkUtils.java @@ -227,14 +227,7 @@ public abstract class NetworkUtils { /** Returns addresses for the given interface (it must be marked up) */ static InetAddress[] getAddressesForInterface(String name) throws SocketException { - NetworkInterface intf = null; - for (NetworkInterface networkInterface : getInterfaces()) { - if (name.equals(networkInterface.getName())) { - intf = networkInterface; - break; - } - } - + NetworkInterface intf = NetworkInterface.getByName(name); if (intf == null) { throw new IllegalArgumentException("No interface named '" + name + "' found, got " + getInterfaces()); } diff --git a/core/src/test/java/org/elasticsearch/common/network/NetworkUtilsTests.java b/core/src/test/java/org/elasticsearch/common/network/NetworkUtilsTests.java index ce76f8ef6d3..e5b95f258a3 100644 --- a/core/src/test/java/org/elasticsearch/common/network/NetworkUtilsTests.java +++ b/core/src/test/java/org/elasticsearch/common/network/NetworkUtilsTests.java @@ -22,10 +22,6 @@ package org.elasticsearch.common.network; import org.elasticsearch.test.ESTestCase; import java.net.InetAddress; -import java.net.NetworkInterface; -import java.util.Arrays; -import java.util.Collections; -import java.util.Enumeration; /** * Tests for network utils. Please avoid using any methods that cause DNS lookups! @@ -78,17 +74,4 @@ public class NetworkUtilsTests extends ESTestCase { assertArrayEquals(new InetAddress[] { InetAddress.getByName("127.0.0.1") }, NetworkUtils.filterIPV4(addresses)); assertArrayEquals(new InetAddress[] { InetAddress.getByName("::1") }, NetworkUtils.filterIPV6(addresses)); } - - /** - * Test that selecting by name is possible and properly matches the addresses on all interfaces and virtual - * interfaces. - */ - public void testAddressInterfaceLookup() throws Exception { - for (NetworkInterface netIf : NetworkUtils.getInterfaces()) { - String name = netIf.getName(); - InetAddress[] expectedAddresses = Collections.list(netIf.getInetAddresses()).toArray(new InetAddress[0]); - InetAddress[] foundAddresses = NetworkUtils.getAddressesForInterface(name); - assertArrayEquals(expectedAddresses, foundAddresses); - } - } }