honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-17 18:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

don't use cache for ordinals for small max ord

Browse Source
This commit is contained in:
Shay Banon 2013-03-07 08:45:01 -08:00
parent 59ea426bf2
commit c298c19177
2 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/org/elasticsearch/search/facet/terms/TermsFacetParser.java
View File

@ -53,10 +53,13 @@ import java.util.regex.Pattern;
*/ */
public class TermsFacetParser extends AbstractComponent implements FacetParser { public class TermsFacetParser extends AbstractComponent implements FacetParser {
private final int ordinalsCacheAbove;
@Inject @Inject
public TermsFacetParser(Settings settings) { public TermsFacetParser(Settings settings) {
super(settings); super(settings);
InternalTermsFacet.registerStreams(); InternalTermsFacet.registerStreams();
this.ordinalsCacheAbove = componentSettings.getAsInt("ordinals_cache_above", 10000); // above 40k we want to cache
} }
@Override @Override
@ -176,7 +179,7 @@ public class TermsFacetParser extends AbstractComponent implements FacetParser {
if (script != null || "map".equals(executionHint)) { if (script != null || "map".equals(executionHint)) {
return new TermsStringFacetExecutor(indexFieldData, size, comparatorType, allTerms, context, excluded, pattern, searchScript); return new TermsStringFacetExecutor(indexFieldData, size, comparatorType, allTerms, context, excluded, pattern, searchScript);
} else if (indexFieldData instanceof IndexFieldData.WithOrdinals) { } else if (indexFieldData instanceof IndexFieldData.WithOrdinals) {
return new TermsStringOrdinalsFacetExecutor((IndexFieldData.WithOrdinals) indexFieldData, size, comparatorType, allTerms, context, excluded, pattern); return new TermsStringOrdinalsFacetExecutor((IndexFieldData.WithOrdinals) indexFieldData, size, comparatorType, allTerms, context, excluded, pattern, ordinalsCacheAbove);
} else { } else {
return new TermsStringFacetExecutor(indexFieldData, size, comparatorType, allTerms, context, excluded, pattern, searchScript); return new TermsStringFacetExecutor(indexFieldData, size, comparatorType, allTerms, context, excluded, pattern, searchScript);
} }

22
src/main/java/org/elasticsearch/search/facet/terms/strings/TermsStringOrdinalsFacetExecutor.java
View File

@ -54,17 +54,19 @@ public class TermsStringOrdinalsFacetExecutor extends FacetExecutor {
private final int minCount; private final int minCount;
private final ImmutableSet<BytesRef> excluded; private final ImmutableSet<BytesRef> excluded;
private final Matcher matcher; private final Matcher matcher;
final int ordinalsCacheAbove;
final List<ReaderAggregator> aggregators; final List<ReaderAggregator> aggregators;
long missing; long missing;
long total; long total;
public TermsStringOrdinalsFacetExecutor(IndexFieldData.WithOrdinals indexFieldData, int size, TermsFacet.ComparatorType comparatorType, boolean allTerms, SearchContext context, public TermsStringOrdinalsFacetExecutor(IndexFieldData.WithOrdinals indexFieldData, int size, TermsFacet.ComparatorType comparatorType, boolean allTerms, SearchContext context,
ImmutableSet<BytesRef> excluded, Pattern pattern) { ImmutableSet<BytesRef> excluded, Pattern pattern, int ordinalsCacheAbove) {
this.indexFieldData = indexFieldData; this.indexFieldData = indexFieldData;
this.size = size; this.size = size;
this.comparatorType = comparatorType; this.comparatorType = comparatorType;
this.numberOfShards = context.numberOfShards(); this.numberOfShards = context.numberOfShards();
this.ordinalsCacheAbove = ordinalsCacheAbove;
if (excluded == null || excluded.isEmpty()) { if (excluded == null || excluded.isEmpty()) {
this.excluded = null; this.excluded = null;
@ -136,7 +138,9 @@ public class TermsStringOrdinalsFacetExecutor extends FacetExecutor {
} }
for (ReaderAggregator aggregator : aggregators) { for (ReaderAggregator aggregator : aggregators) {
CacheRecycler.pushIntArray(aggregator.counts); if (aggregator.counts.length > ordinalsCacheAbove) {
CacheRecycler.pushIntArray(aggregator.counts);
}
} }
return new InternalStringTermsFacet(facetName, comparatorType, size, Arrays.asList(list), missing, total); return new InternalStringTermsFacet(facetName, comparatorType, size, Arrays.asList(list), missing, total);
@ -174,7 +178,9 @@ public class TermsStringOrdinalsFacetExecutor extends FacetExecutor {
for (ReaderAggregator aggregator : aggregators) { for (ReaderAggregator aggregator : aggregators) {
CacheRecycler.pushIntArray(aggregator.counts); if (aggregator.counts.length > ordinalsCacheAbove) {
CacheRecycler.pushIntArray(aggregator.counts);
}
} }
return new InternalStringTermsFacet(facetName, comparatorType, size, ordered, missing, total); return new InternalStringTermsFacet(facetName, comparatorType, size, ordered, missing, total);
@ -197,7 +203,7 @@ public class TermsStringOrdinalsFacetExecutor extends FacetExecutor {
} }
} }
values = indexFieldData.load(context).getBytesValues(); values = indexFieldData.load(context).getBytesValues();
current = new ReaderAggregator(values); current = new ReaderAggregator(values, ordinalsCacheAbove);
} }
@Override @Override
@ -231,11 +237,15 @@ public class TermsStringOrdinalsFacetExecutor extends FacetExecutor {
int total; int total;
private final int maxOrd; private final int maxOrd;
public ReaderAggregator(BytesValues.WithOrdinals values) { public ReaderAggregator(BytesValues.WithOrdinals values, int ordinalsCacheLimit) {
this.values = values; this.values = values;
this.maxOrd = values.ordinals().getMaxOrd(); this.maxOrd = values.ordinals().getMaxOrd();
this.counts = CacheRecycler.popIntArray(maxOrd); if (maxOrd > ordinalsCacheLimit) {
this.counts = CacheRecycler.popIntArray(maxOrd);
} else {
this.counts = new int[maxOrd];
}
} }
@Override @Override