honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-23 13:26:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Switch to ConstructingObjectParser

Browse Source
This commit is contained in:
Isabel Drost-Fromm 2016-08-09 12:22:44 +02:00
parent 978d5366d2
commit c2bd58e13d
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
modules/rank-eval/src/main/java/org/elasticsearch/index/rankeval/RatedDocument.java
View File

@ -25,7 +25,7 @@ import org.elasticsearch.common.ParsingException;
import org.elasticsearch.common.io.stream.StreamInput; import org.elasticsearch.common.io.stream.StreamInput;
import org.elasticsearch.common.io.stream.StreamOutput; import org.elasticsearch.common.io.stream.StreamOutput;
import org.elasticsearch.common.io.stream.Writeable; import org.elasticsearch.common.io.stream.Writeable;
import org.elasticsearch.common.xcontent.ObjectParser; import org.elasticsearch.common.xcontent.ConstructingObjectParser;
import org.elasticsearch.common.xcontent.XContentBuilder; import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.common.xcontent.XContentParser; import org.elasticsearch.common.xcontent.XContentParser;
@ -40,24 +40,23 @@ public class RatedDocument extends ToXContentToBytes implements Writeable {
public static final ParseField RATING_FIELD = new ParseField("rating"); public static final ParseField RATING_FIELD = new ParseField("rating");
public static final ParseField KEY_FIELD = new ParseField("key"); public static final ParseField KEY_FIELD = new ParseField("key");
private static final ObjectParser<RatedDocument, RankEvalContext> PARSER = new ObjectParser<>("ratings", RatedDocument::new); private static final ConstructingObjectParser<RatedDocument, RankEvalContext> PARSER = new ConstructingObjectParser<>("rated_document",
a -> new RatedDocument((RatedDocumentKey) a[0], (Integer) a[1]));
static { static {
PARSER.declareObject(RatedDocument::setKey, (p, c) -> { PARSER.declareObject(ConstructingObjectParser.constructorArg(), (p, c) -> {
try { try {
return RatedDocumentKey.fromXContent(p, c); return RatedDocumentKey.fromXContent(p, c);
} catch (IOException ex) { } catch (IOException ex) {
throw new ParsingException(p.getTokenLocation(), "error parsing rank request", ex); throw new ParsingException(p.getTokenLocation(), "error parsing rank request", ex);
} }
} , KEY_FIELD); } , KEY_FIELD);
PARSER.declareInt(RatedDocument::setRating, RATING_FIELD); PARSER.declareInt(ConstructingObjectParser.constructorArg(), RATING_FIELD);
} }
private RatedDocumentKey key; private RatedDocumentKey key;
private int rating; private int rating;
RatedDocument() {}
void setRatedDocumentKey(RatedDocumentKey key) { void setRatedDocumentKey(RatedDocumentKey key) {
this.key = key; this.key = key;
} }
@ -95,7 +94,7 @@ public class RatedDocument extends ToXContentToBytes implements Writeable {
} }
public static RatedDocument fromXContent(XContentParser parser, RankEvalContext context) throws IOException { public static RatedDocument fromXContent(XContentParser parser, RankEvalContext context) throws IOException {
return PARSER.parse(parser, context); return PARSER.apply(parser, context);
} }
@Override @Override