From c341b41c547d4c32d11500799b0091e4b6960b15 Mon Sep 17 00:00:00 2001 From: Zachary Tong Date: Tue, 10 Apr 2018 20:45:33 +0000 Subject: [PATCH] [TEST] Temporarily silence MovAvgIT tests due to change in double comparisons #29409 removed the nearlyEquals() double comparison snippet, which makes these tests very flaky because they can generate very large or very small doubles which don't work well with absolute error comparison. We need to either refactor these tests to guarantee they stay in a small range (which could be difficult due to holt/holt-winters) or re-implement the more robust double comparison. Tracking issue: #29456 --- .../search/aggregations/pipeline/moving/avg/MovAvgIT.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/server/src/test/java/org/elasticsearch/search/aggregations/pipeline/moving/avg/MovAvgIT.java b/server/src/test/java/org/elasticsearch/search/aggregations/pipeline/moving/avg/MovAvgIT.java index 844fc671823..159b7e28b12 100644 --- a/server/src/test/java/org/elasticsearch/search/aggregations/pipeline/moving/avg/MovAvgIT.java +++ b/server/src/test/java/org/elasticsearch/search/aggregations/pipeline/moving/avg/MovAvgIT.java @@ -19,6 +19,7 @@ package org.elasticsearch.search.aggregations.pipeline.moving.avg; +import org.apache.lucene.util.LuceneTestCase; import org.elasticsearch.action.bulk.BulkRequestBuilder; import org.elasticsearch.action.bulk.BulkResponse; import org.elasticsearch.action.index.IndexRequestBuilder; @@ -67,6 +68,7 @@ import static org.hamcrest.Matchers.is; import static org.hamcrest.core.IsNull.notNullValue; import static org.hamcrest.core.IsNull.nullValue; +@LuceneTestCase.AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/29456") @ESIntegTestCase.SuiteScopeTestCase public class MovAvgIT extends ESIntegTestCase { private static final String INTERVAL_FIELD = "l_value"; @@ -600,6 +602,7 @@ public class MovAvgIT extends ESIntegTestCase { } } + public void testHoltWintersValuedField() { SearchResponse response = client() .prepareSearch("idx").setTypes("type")