honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix a timing issue: isFinished is used for a busy loop in testing, (#41055) 

test: ensure state is persisted before the isFinished is changed

fixes #41046
This commit is contained in:
Hendrik Muhs 2019-04-10 18:43:41 +02:00
parent e611334b2b
commit c37b127a07
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/job/RollupIndexerStateTests.java
View File

@ -256,7 +256,6 @@ public class RollupIndexerStateTests extends ESTestCase {
}
}
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/41046")
public void testIndexing() throws Exception {
RollupJob job = new RollupJob(ConfigTestHelpers.randomRollupJobConfig(random()), Collections.emptyMap());
AtomicReference<IndexerState> state = new AtomicReference<>(IndexerState.STOPPED);
@ -267,8 +266,8 @@ public class RollupIndexerStateTests extends ESTestCase {
@Override
protected void onFinish(ActionListener<Void> listener) {
super.onFinish(ActionListener.wrap(r -> {
isFinished.set(true);
listener.onResponse(r);
isFinished.set(true);
}, listener::onFailure));
}
};
@ -316,8 +315,8 @@ public class RollupIndexerStateTests extends ESTestCase {
@Override
protected void onFinish(ActionListener<Void> listener) {
super.onFinish(ActionListener.wrap(r -> {
isFinished.set(true);
listener.onResponse(r);
isFinished.set(true);
}, listener::onFailure));
}
};