Don't throw set exception if it is an error based exception, this breaks how we deal with assertions in general.

This commit is contained in:
Martijn van Groningen 2013-09-17 17:19:50 +02:00
parent ddc2b428d6
commit ca8b3ac0ba
1 changed files with 6 additions and 3 deletions

View File

@ -182,9 +182,12 @@ public abstract class BaseFuture<V> implements Future<V> {
// If it's an Error, we want to make sure it reaches the top of the
// call stack, so we rethrow it.
if (throwable instanceof Error) {
throw (Error) throwable;
}
// we want to notify the listeners we have with errors as well, as it breaks
// how we work in ES in terms of using assertions
// if (throwable instanceof Error) {
// throw (Error) throwable;
// }
return result;
}