honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reduce composite references at network level (#36400) 

Creating `CompositeBytesReference` has more overhead than a single
`ByteBufferReference`. Many of our messages will be contained to a
single `ByteBuffer`. This commit avoids creating composite instances
when there is 0 or 1  underlying `ByteBuffers`.
This commit is contained in:
Tim Brooks 2018-12-08 14:24:38 -07:00 committed by GitHub
parent b5b6e37a60
commit cc3872d934
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/src/main/java/org/elasticsearch/common/bytes/ByteBufferReference.java
View File

@ -25,8 +25,8 @@ import java.nio.ByteBuffer;
/**
* This is a {@link BytesReference} backed by a {@link ByteBuffer}. The byte buffer can either be a heap or
* direct byte buffer. The reference is composed of the space between the {@link ByteBuffer#position} and
* {@link ByteBuffer#limit} at construction time. If the position or limit of the underlying byte buffer is
* direct byte buffer. The reference is composed of the space between the {@link ByteBuffer#position()} and
* {@link ByteBuffer#limit()} at construction time. If the position or limit of the underlying byte buffer is
* changed, those changes will not be reflected in this reference. However, modifying the limit or position
* of the underlying byte buffer is not recommended as those can be used during {@link ByteBuffer#get()}
* bounds checks. Use {@link ByteBuffer#duplicate()} at creation time if you plan on modifying the markers of

19
server/src/main/java/org/elasticsearch/common/bytes/BytesReference.java
View File

@ -195,17 +195,24 @@ public abstract class BytesReference implements Comparable<BytesReference>, ToXC
* Returns BytesReference composed of the provided ByteBuffers.
*/
public static BytesReference fromByteBuffers(ByteBuffer[] buffers) {
ByteBufferReference[] references = new ByteBufferReference[buffers.length];
for (int i = 0; i < references.length; ++i) {
references[i] = new ByteBufferReference(buffers[i]);
}
int bufferCount = buffers.length;
if (bufferCount == 0) {
return BytesArray.EMPTY;
} else if (bufferCount == 1) {
return new ByteBufferReference(buffers[0]);
} else {
ByteBufferReference[] references = new ByteBufferReference[bufferCount];
for (int i = 0; i < bufferCount; ++i) {
references[i] = new ByteBufferReference(buffers[i]);
}
return new CompositeBytesReference(references);
return new CompositeBytesReference(references);
}
}
@Override
public int compareTo(final BytesReference other) {
return compareIterators(this, other, (a, b) -> a.compareTo(b));
return compareIterators(this, other, BytesRef::compareTo);
}
/**