honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Query DSL: don't cache type filter in DocumentMapper 

If we cache the type filter and we e.g. set its boost which is now settable on all queries, the boost will change for all subsequent queries. We should rather create a new query every time.
This commit is contained in:
javanna 2015-07-24 18:37:17 +02:00 committed by Luca Cavanna
parent db5d73a617
commit cf570ac5bd
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/main/java/org/elasticsearch/index/mapper/DocumentMapper.java
View File

@ -168,8 +168,6 @@ public class DocumentMapper implements ToXContent {
private boolean hasNestedObjects = false;
private final Query typeFilter;
private final ReleasableLock mappingWriteLock;
private final ReentrantReadWriteLock mappingLock;
@ -190,7 +188,6 @@ public class DocumentMapper implements ToXContent {
meta);
this.documentParser = new DocumentParser(indexSettings, docMapperParser, this, new ReleasableLock(mappingLock.readLock()));
this.typeFilter = typeMapper().fieldType().termQuery(type, null);
this.mappingWriteLock = new ReleasableLock(mappingLock.writeLock());
this.mappingLock = mappingLock;
@ -307,7 +304,7 @@ public class DocumentMapper implements ToXContent {
}
public Query typeFilter() {
return this.typeFilter;
return typeMapper().fieldType().termQuery(type, null);
}
public boolean hasNestedObjects() {