Removed perl 5.8 support from the license checker

No point in keeping 5.8 support because it relies on modules
that are shipped with 5.9.

dev-tools/src/main/resources/license-check/check_license_and_sha.pl

@@ -2,6 +2,7 @@
 
 use strict;
 use warnings;
+use v5.10;
 
 use FindBin qw($RealBin);
 use lib "$RealBin/lib";
@@ -10,20 +11,9 @@ use File::Temp();
 use File::Find();
 use File::Basename qw(basename);
 use Archive::Extract();
+use Digest::SHA();
 $Archive::Extract::PREFER_BIN = 1;
 
-our $SHA_CLASS = 'Digest::SHA';
-if ( eval { require Digest::SHA } ) {
-    $SHA_CLASS = 'Digest::SHA';
-}
-else {
-
-    print STDERR "Digest::SHA not available. "
-        . "Falling back to Digest::SHA::PurePerl\n";
-    require Digest::SHA::PurePerl;
-    $SHA_CLASS = 'Digest::SHA::PurePerl';
-}
-
 my $mode = shift(@ARGV) || "";
 die usage() unless $mode =~ /^--(check|update)$/;
 
@@ -32,8 +22,8 @@ my $Source      = shift(@ARGV) || die usage();
 $License_Dir = File::Spec->rel2abs($License_Dir) . '/';
 $Source      = File::Spec->rel2abs($Source);
 
-print "LICENSE DIR: $License_Dir\n";
+say "LICENSE DIR: $License_Dir";
-print "SOURCE: $Source\n";
+say "SOURCE: $Source";
 
 die "License dir is not a directory: $License_Dir\n" . usage()
     unless -d $License_Dir;
@@ -62,15 +52,15 @@ sub check_shas_and_licenses {
     for my $jar ( sort keys %new ) {
         my $old_sha = delete $old{$jar};
         unless ($old_sha) {
-            print STDERR "$jar: SHA is missing\n";
+            say STDERR "$jar: SHA is missing";
             $error++;
             $sha_error++;
             next;
         }
 
         unless ( $old_sha eq $new{$jar} ) {
-            print STDERR
+            say STDERR
-                "$jar: SHA has changed, expected $old_sha but found $new{$jar}\n";
+                "$jar: SHA has changed, expected $old_sha but found $new{$jar}";
             $error++;
             $sha_error++;
             next;
@@ -98,41 +88,37 @@ sub check_shas_and_licenses {
             }
         }
         unless ($license_found) {
-            print STDERR "$jar: LICENSE is missing\n";
+            say STDERR "$jar: LICENSE is missing";
             $error++;
             $sha_error++;
         }
         unless ($notice_found) {
-            print STDERR "$jar: NOTICE is missing\n";
+            say STDERR "$jar: NOTICE is missing";
             $error++;
         }
     }
 
     if ( keys %old ) {
-        print STDERR "Extra SHA files present for: " . join ", ",
+        say STDERR "Extra SHA files present for: " . join ", ", sort keys %old;
-            sort keys %old;
-        print "\n";
         $error++;
     }
 
     my @unused_licenses = grep { !$licenses{$_} } keys %licenses;
     if (@unused_licenses) {
         $error++;
-        print STDERR "Extra LICENCE file present: " . join ", ",
+        say STDERR "Extra LICENCE file present: " . join ", ",
             sort @unused_licenses;
-        print "\n";
     }
 
     my @unused_notices = grep { !$notices{$_} } keys %notices;
     if (@unused_notices) {
         $error++;
-        print STDERR "Extra NOTICE file present: " . join ", ",
+        say STDERR "Extra NOTICE file present: " . join ", ",
             sort @unused_notices;
-        print "\n";
     }
 
     if ($sha_error) {
-        print STDERR <<"SHAS"
+        say STDERR <<"SHAS"
 
 You can update the SHA files by running:
 
@@ -140,7 +126,7 @@ $0 --update $License_Dir $Source
 
 SHAS
     }
-    print("All SHAs and licenses OK\n") unless $error;
+    say("All SHAs and licenses OK") unless $error;
     return $error;
 }
 
@@ -153,13 +139,13 @@ sub write_shas {
     for my $jar ( sort keys %new ) {
         if ( $old{$jar} ) {
             next if $old{$jar} eq $new{$jar};
-            print "Updating $jar\n";
+            say "Updating $jar";
         }
         else {
-            print "Adding $jar\n";
+            say "Adding $jar";
         }
         open my $fh, '>', $License_Dir . $jar or die $!;
-        print $fh $new{$jar} . "\n" or die $!;
+        say $fh $new{$jar} or die $!;
         close $fh or die $!;
     }
     continue {
@@ -167,10 +153,10 @@ sub write_shas {
     }
 
     for my $jar ( sort keys %old ) {
-        print "Deleting $jar\n";
+        say "Deleting $jar";
         unlink $License_Dir . $jar or die $!;
     }
-    print "SHAs updated\n";
+    say "SHAs updated";
     return 0;
 }
 
@@ -240,7 +226,7 @@ sub calculate_shas {
 #===================================
     my %shas;
     while ( my $file = shift() ) {
-        my $digest = eval { $SHA_CLASS->new(1)->addfile($file) }
+        my $digest = eval { Digest::SHA->new(1)->addfile($file) }
             or die "Error calculating SHA1 for <$file>: $!\n";
         $shas{ basename($file) . ".sha1" } = $digest->hexdigest;
     }