honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix NPE in toString of FailedShard (#64770) (#64779) 

The concatenation took precedence over the null check, leading to an NPE
because `null` was passed to `ExceptionsHelper.stackTrace(failure))`.
This commit is contained in:
Armin Braun 2020-11-09 17:02:11 +01:00 committed by GitHub
parent 7360a58b49
commit d173ba6b2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/src/main/java/org/elasticsearch/cluster/routing/allocation/FailedShard.java
View File

@ -43,7 +43,7 @@ public class FailedShard {
@Override @Override
public String toString() { public String toString() {
return "failed shard, shard " + routingEntry + ", message [" + message + "], failure [" + return "failed shard, shard " + routingEntry + ", message [" + message + "], failure [" +
failure == null ? "null" : ExceptionsHelper.detailedMessage(failure) + "], markAsStale [" + markAsStale + "]"; (failure == null ? "null" : ExceptionsHelper.detailedMessage(failure)) + "], markAsStale [" + markAsStale + "]";
} }
/** /**