honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Provide a better error message for the case when all shards failed (#28333) 

Today we don't specify a cause which can make debugging very very tricky.
This change is best effort to supply at least one cause for the failure.
This commit is contained in:
Simon Willnauer 2018-01-23 14:50:02 +01:00 committed by GitHub
parent ba9e2e44cb
commit d31e964a86
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/src/main/java/org/elasticsearch/action/search/AbstractSearchAsyncAction.java
View File

@ -122,14 +122,14 @@ abstract class AbstractSearchAsyncAction<Result extends SearchPhaseResult> exten
* at least one successful operation left and if so we move to the next phase. If not we immediately fail the * at least one successful operation left and if so we move to the next phase. If not we immediately fail the
* search phase as "all shards failed"*/ * search phase as "all shards failed"*/
if (successfulOps.get() == 0) { // we have 0 successful results that means we shortcut stuff and return a failure if (successfulOps.get() == 0) { // we have 0 successful results that means we shortcut stuff and return a failure
if (logger.isDebugEnabled()) {
final ShardOperationFailedException[] shardSearchFailures = ExceptionsHelper.groupBy(buildShardFailures()); final ShardOperationFailedException[] shardSearchFailures = ExceptionsHelper.groupBy(buildShardFailures());
Throwable cause = shardSearchFailures.length == 0 ? null : Throwable cause = shardSearchFailures.length == 0 ? null :
ElasticsearchException.guessRootCauses(shardSearchFailures[0].getCause())[0]; ElasticsearchException.guessRootCauses(shardSearchFailures[0].getCause())[0];
if (logger.isDebugEnabled()) {
logger.debug((Supplier<?>) () -> new ParameterizedMessage("All shards failed for phase: [{}]", getName()), logger.debug((Supplier<?>) () -> new ParameterizedMessage("All shards failed for phase: [{}]", getName()),
cause); cause);
} }
onPhaseFailure(currentPhase, "all shards failed", null); onPhaseFailure(currentPhase, "all shards failed", cause);
} else { } else {
if (logger.isTraceEnabled()) { if (logger.isTraceEnabled()) {
final String resultsFrom = results.getSuccessfulResults() final String resultsFrom = results.getSuccessfulResults()