fix comments and throw ElasticsearchException when we fail to report fst index size

This commit is contained in:
Areek Zillur 2015-11-07 17:27:20 -05:00
parent d37e011526
commit d5198b326c
2 changed files with 4 additions and 2 deletions

View File

@ -25,6 +25,7 @@ import org.apache.lucene.index.LeafReader;
import org.apache.lucene.index.LeafReaderContext;
import org.apache.lucene.index.Terms;
import org.apache.lucene.search.suggest.document.CompletionTerms;
import org.elasticsearch.ElasticsearchException;
import org.elasticsearch.common.regex.Regex;
import java.io.IOException;
@ -43,7 +44,7 @@ public class CompletionFieldStats {
for (String fieldName : atomicReader.fields()) {
Terms terms = atomicReader.fields().terms(fieldName);
if (terms instanceof CompletionTerms) {
// TODO: currently we load up the suggester for reporting it's size
// TODO: currently we load up the suggester for reporting its size
long fstSize = ((CompletionTerms) terms).suggester().ramBytesUsed();
if (fields != null && fields.length > 0 && Regex.simpleMatch(fields, fieldName)) {
completionFields.addTo(fieldName, fstSize);
@ -52,7 +53,7 @@ public class CompletionFieldStats {
}
}
} catch (IOException ignored) {
throw new RuntimeException(ignored);
throw new ElasticsearchException(ignored);
}
}
return new CompletionStats(sizeInBytes, completionFields);

View File

@ -117,6 +117,7 @@ public class CompletionSuggester extends Suggester<CompletionSuggestionContext>
}
// TODO: this should be refactored and moved to lucene
// see https://issues.apache.org/jira/browse/LUCENE-6880
private final static class TopDocumentsCollector extends TopSuggestDocsCollector {
/**