Add comments to SqlSession

Original commit: elastic/x-pack-elasticsearch@82291d41c8
This commit is contained in:
Costin Leau 2017-09-28 20:54:29 +03:00
parent aca8a5b6c0
commit d634314dd1
4 changed files with 11 additions and 3 deletions

View File

@ -34,7 +34,7 @@ import static org.hamcrest.Matchers.arrayWithSize;
* Tests comparing sql queries executed against our jdbc client * Tests comparing sql queries executed against our jdbc client
* with hard coded result sets. * with hard coded result sets.
*/ */
public class CsvSpecTestCase extends SpecBaseIntegrationTestCase { public abstract class CsvSpecTestCase extends SpecBaseIntegrationTestCase {
private final CsvTestCase testCase; private final CsvTestCase testCase;
@ParametersFactory(argumentFormatting = PARAM_FORMATTING) @ParametersFactory(argumentFormatting = PARAM_FORMATTING)

View File

@ -19,7 +19,7 @@ import java.util.List;
* Tests comparing sql queries executed against our jdbc client * Tests comparing sql queries executed against our jdbc client
* with those executed against H2's jdbc client. * with those executed against H2's jdbc client.
*/ */
public class SqlSpecTestCase extends SpecBaseIntegrationTestCase { public abstract class SqlSpecTestCase extends SpecBaseIntegrationTestCase {
private String query; private String query;
@ClassRule @ClassRule

View File

@ -266,7 +266,6 @@ public class Analyzer extends RuleExecutor<LogicalPlan> {
} }
if (found == null) { if (found == null) {
return plan; return plan;
//throw new UnknownIndexException(table.index(), plan);
} }
LogicalPlan catalogTable = new EsRelation(plan.location(), found); LogicalPlan catalogTable = new EsRelation(plan.location(), found);

View File

@ -25,6 +25,15 @@ public class UnresolvedFunction extends Function implements Unresolvable {
this(location, name, distinct, children, null); this(location, name, distinct, children, null);
} }
/**
* Constructor used for specifying a more descriptive message (typically 'did you mean') instead of the default one.
*
* @param location
* @param name
* @param distinct
* @param children
* @param unresolvedMessage
*/
public UnresolvedFunction(Location location, String name, boolean distinct, List<Expression> children, String unresolvedMessage) { public UnresolvedFunction(Location location, String name, boolean distinct, List<Expression> children, String unresolvedMessage) {
super(location, children); super(location, children);
this.name = name; this.name = name;