Fix additional exception logging calls

This commit modifies a pair of exception logging calls to use
parameterized messages from Log4j.
This commit is contained in:
Jason Tedor 2016-08-31 23:14:13 -04:00
parent c98e790772
commit d9064f454e
2 changed files with 9 additions and 2 deletions

View File

@ -20,6 +20,8 @@
package org.elasticsearch.action.support;
import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.message.ParameterizedMessage;
import org.apache.logging.log4j.util.Supplier;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.client.Client;
import org.elasticsearch.client.transport.TransportClient;
@ -118,7 +120,8 @@ public final class ThreadedActionListener<Response> implements ActionListener<Re
@Override
public void onFailure(Exception e) {
logger.warn("failed to execute failure callback on [{}], failure [{}]", e, listener, e);
logger.warn(
(Supplier<?>) () -> new ParameterizedMessage("failed to execute failure callback on [{}]", listener), e);
}
});
}

View File

@ -18,6 +18,8 @@
*/
package org.elasticsearch.transport.netty3;
import org.apache.logging.log4j.message.ParameterizedMessage;
import org.apache.logging.log4j.util.Supplier;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.BytesRefIterator;
import org.elasticsearch.common.SuppressForbidden;
@ -121,7 +123,9 @@ public class Netty3Utils {
}
});
} catch (final SecurityException e) {
Loggers.getLogger(Netty3Utils.class).debug("Unable to get/set System Property: {}", e, key);
Loggers
.getLogger(Netty3Utils.class)
.debug((Supplier<?>) () -> new ParameterizedMessage("Unable to get/set System Property: {}", key), e);
}
}
}