Inline TaskManager#register
This commit is contained in:
parent
8078c205f9
commit
dcd394d83f
|
@ -92,23 +92,7 @@ public class TaskManager extends AbstractComponent implements ClusterStateListen
|
||||||
}
|
}
|
||||||
|
|
||||||
if (task instanceof CancellableTask) {
|
if (task instanceof CancellableTask) {
|
||||||
CancellableTask cancellableTask = (CancellableTask) task;
|
registerCancellableTask(task);
|
||||||
CancellableTaskHolder holder = new CancellableTaskHolder(cancellableTask);
|
|
||||||
CancellableTaskHolder oldHolder = cancellableTasks.put(task.getId(), holder);
|
|
||||||
assert oldHolder == null;
|
|
||||||
// Check if this task was banned before we start it
|
|
||||||
if (task.getParentTaskId().isSet() && banedParents.isEmpty() == false) {
|
|
||||||
String reason = banedParents.get(task.getParentTaskId());
|
|
||||||
if (reason != null) {
|
|
||||||
try {
|
|
||||||
holder.cancel(reason);
|
|
||||||
throw new IllegalStateException("Task cancelled before it started: " + reason);
|
|
||||||
} finally {
|
|
||||||
// let's clean up the registration
|
|
||||||
unregister(task);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
Task previousTask = tasks.put(task.getId(), task);
|
Task previousTask = tasks.put(task.getId(), task);
|
||||||
assert previousTask == null;
|
assert previousTask == null;
|
||||||
|
@ -116,6 +100,26 @@ public class TaskManager extends AbstractComponent implements ClusterStateListen
|
||||||
return task;
|
return task;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private void registerCancellableTask(Task task) {
|
||||||
|
CancellableTask cancellableTask = (CancellableTask) task;
|
||||||
|
CancellableTaskHolder holder = new CancellableTaskHolder(cancellableTask);
|
||||||
|
CancellableTaskHolder oldHolder = cancellableTasks.put(task.getId(), holder);
|
||||||
|
assert oldHolder == null;
|
||||||
|
// Check if this task was banned before we start it
|
||||||
|
if (task.getParentTaskId().isSet() && banedParents.isEmpty() == false) {
|
||||||
|
String reason = banedParents.get(task.getParentTaskId());
|
||||||
|
if (reason != null) {
|
||||||
|
try {
|
||||||
|
holder.cancel(reason);
|
||||||
|
throw new IllegalStateException("Task cancelled before it started: " + reason);
|
||||||
|
} finally {
|
||||||
|
// let's clean up the registration
|
||||||
|
unregister(task);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Cancels a task
|
* Cancels a task
|
||||||
* <p>
|
* <p>
|
||||||
|
|
Loading…
Reference in New Issue