honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

TEST: Avoid invalid ranges in ShardChangesActionTests (#33976) 

If numWrites is between 2 and 9, we will issue an invalid range because
the from_seq_no is negative. This commit makes sure that numWrites is at
least 10, and adds an explicit test to verify invalid request ranges.
This commit is contained in:
Nhat Nguyen 2018-09-23 22:28:41 -04:00 committed by GitHub
parent df521c1d3e
commit ddd5ce5740
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
x-pack/plugin/ccr/src/test/java/org/elasticsearch/xpack/ccr/action/ShardChangesActionTests.java
View File

@ -49,7 +49,7 @@ public class ShardChangesActionTests extends ESSingleNodeTestCase {
.build();
final IndexService indexService = createIndex("index", settings);
final int numWrites = randomIntBetween(2, 4096);
final int numWrites = randomIntBetween(10, 4096);
for (int i = 0; i < numWrites; i++) {
client().prepareIndex("index", "doc", Integer.toString(i)).setSource("{}", XContentType.JSON).get();
}
@ -97,6 +97,17 @@ public class ShardChangesActionTests extends ESSingleNodeTestCase {
indexShard.getGlobalCheckpoint(), 0, 10, "different-history-uuid", Long.MAX_VALUE));
assertThat(e.getMessage(), equalTo("unexpected history uuid, expected [different-history-uuid], actual [" +
indexShard.getHistoryUUID() + "]"));
// invalid range
{
final long fromSeqNo = randomLongBetween(Long.MIN_VALUE, -1);
final int batchSize = randomIntBetween(0, Integer.MAX_VALUE);
final IllegalArgumentException invalidRangeError = expectThrows(IllegalArgumentException.class,
() -> ShardChangesAction.getOperations(indexShard, indexShard.getGlobalCheckpoint(),
fromSeqNo, batchSize, indexShard.getHistoryUUID(), Long.MAX_VALUE));
assertThat(invalidRangeError.getMessage(),
equalTo("Invalid range; from_seqno [" + fromSeqNo + "], to_seqno [" + (fromSeqNo + batchSize - 1) + "]"));
}
}
public void testGetOperationsWhenShardNotStarted() throws Exception {