honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

use switch for status codes and add comments

This commit is contained in:
javanna 2016-06-09 16:51:08 +02:00 committed by Luca Cavanna
parent cbdffc7965
commit de8b9fd579
1 changed files with 23 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
client/src/main/java/org/elasticsearch/client/RestClient.java
View File

@ -171,31 +171,33 @@ public final class RestClient implements Closeable {
RequestLogger.log(logger, "request succeeded", request, host, httpResponse); RequestLogger.log(logger, "request succeeded", request, host, httpResponse);
onSuccess(host); onSuccess(host);
return response; return response;
} else { }
RequestLogger.log(logger, "request failed", request, host, httpResponse); RequestLogger.log(logger, "request failed", request, host, httpResponse);
String responseBody; String responseBody;
try { try {
if (response.getEntity() == null) { if (response.getEntity() == null) {
responseBody = null; responseBody = null;
} else {
responseBody = EntityUtils.toString(response.getEntity());
}
} finally {
response.close();
}
ResponseException responseException = new ResponseException(
response, responseBody);
lastSeenException = addSuppressedException(lastSeenException, responseException);
//clients don't retry on 500 because elasticsearch still misuses it instead of 400 in some places
if (statusCode == 502 || statusCode == 503 || statusCode == 504) {
onFailure(host);
} else { } else {
//don't retry and call onSuccess as the error should be a request problem, the node is alive responseBody = EntityUtils.toString(response.getEntity());
onSuccess(host);
break;
} }
} finally {
response.close();
}
lastSeenException = addSuppressedException(lastSeenException, new ResponseException(response, responseBody));
switch(statusCode) {
case 502:
case 503:
case 504:
//mark host dead and retry against next one
onFailure(host);
break;
default:
//mark host alive and don't retry, as the error should be a request problem
onSuccess(host);
throw lastSeenException;
} }
} }
//we get here only when we tried all nodes and they all failed
assert lastSeenException != null; assert lastSeenException != null;
throw lastSeenException; throw lastSeenException;
} }