Remove -Xlint exclusions in all plugins. (#40721)

The xlint exclusions of the following plugins were removed:
* ingest-attachment.
* mapper-size.
* transport-nio. Removing the -try exclusion required some work, because
  the NettyAdaptor implements AutoCloseable and NettyAdaptor#close() method
  could throw an InterruptedException (ChannelFuture#await() and a generic
  Exception is re-thrown, which maybe an ChannelFuture). The easiest way
  around this to me seemed that NettyAdaptor should not implement AutoCloseable,
  because it is not directly used in a try-with-resources statement.

Relates to #40366
This commit is contained in:
Martijn van Groningen 2019-04-04 08:29:42 +02:00
parent 1a30ab22fb
commit e5cec87697
No known key found for this signature in database
GPG Key ID: AB236F4FCF2AF12A
5 changed files with 2 additions and 13 deletions

View File

@ -68,10 +68,6 @@ dependencies {
compile "org.apache.james:apache-mime4j-dom:${versions.mime4j}"
}
// TODO: stop using LanguageIdentifier...
compileJava.options.compilerArgs << "-Xlint:-deprecation"
dependencyLicenses {
mapping from: /apache-mime4j-.*/, to: 'apache-mime4j'
}

View File

@ -112,6 +112,7 @@ public final class AttachmentProcessor extends AbstractProcessor {
}
if (properties.contains(Property.LANGUAGE) && Strings.hasLength(parsedContent)) {
// TODO: stop using LanguageIdentifier...
LanguageIdentifier identifier = new LanguageIdentifier(parsedContent);
String language = identifier.getLanguage();
additionalFields.put(Property.LANGUAGE.toLowerCase(), language);

View File

@ -21,7 +21,3 @@ esplugin {
description 'The Mapper Size plugin allows document to record their uncompressed size at index time.'
classname 'org.elasticsearch.plugin.mapper.MapperSizePlugin'
}
// TODO: migrate to points
compileJava.options.compilerArgs << "-Xlint:-deprecation"
compileTestJava.options.compilerArgs << "-Xlint:-deprecation"

View File

@ -24,9 +24,6 @@ esplugin {
hasClientJar = true
}
compileJava.options.compilerArgs << "-Xlint:-try"
compileTestJava.options.compilerArgs << "-Xlint:-rawtypes,-unchecked"
dependencies {
compile "org.elasticsearch:elasticsearch-nio:${version}"

View File

@ -36,7 +36,7 @@ import java.nio.ByteBuffer;
import java.util.LinkedList;
import java.util.function.BiConsumer;
public class NettyAdaptor implements AutoCloseable {
class NettyAdaptor {
private final EmbeddedChannel nettyChannel;
private final LinkedList<FlushOperation> flushOperations = new LinkedList<>();
@ -64,7 +64,6 @@ public class NettyAdaptor implements AutoCloseable {
nettyChannel.pipeline().addLast(handlers);
}
@Override
public void close() throws Exception {
assert flushOperations.isEmpty() : "Should close outbound operations before calling close";