From e61f87d5ff73ee96a11c4d2387e6b44ad071cd2f Mon Sep 17 00:00:00 2001 From: jaymode Date: Thu, 23 Feb 2017 12:34:06 -0500 Subject: [PATCH] Test: do not use the same name twice In rare cases, the CertificateToolTests#testPromptingForInstanceInformation could try to use the same name multiple times. This causes the test to fail with a message for an unknown prompt. This commit ensures no duplicates are added. relates elastic/x-pack-elasticsearch#597 Original commit: elastic/x-pack-elasticsearch@ab8bb7ad50d4e523dc4d568cf34d2d161dc709ec --- .../elasticsearch/xpack/ssl/CertificateToolTests.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/plugin/src/test/java/org/elasticsearch/xpack/ssl/CertificateToolTests.java b/plugin/src/test/java/org/elasticsearch/xpack/ssl/CertificateToolTests.java index 7c13b81a90f..6970e99f80c 100644 --- a/plugin/src/test/java/org/elasticsearch/xpack/ssl/CertificateToolTests.java +++ b/plugin/src/test/java/org/elasticsearch/xpack/ssl/CertificateToolTests.java @@ -120,7 +120,14 @@ public class CertificateToolTests extends ESTestCase { final int numberOfInstances = scaledRandomIntBetween(1, 12); Map> instanceInput = new HashMap<>(numberOfInstances); for (int i = 0; i < numberOfInstances; i++) { - final String name = getValidRandomInstanceName(); + final String name; + while (true) { + String randomName = getValidRandomInstanceName(); + if (instanceInput.containsKey(randomName) == false) { + name = randomName; + break; + } + } Map instanceInfo = new HashMap<>(); instanceInput.put(name, instanceInfo); instanceInfo.put("ip", randomFrom("127.0.0.1", "::1", "192.168.1.1,::1", ""));