honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ML] Cleans up some NORELEASES (elastic/x-pack-elasticsearch#830) 

This change cleans up some NORELEASE comments that are either no longer relevant or actually should be TODO comments

Original commit: elastic/x-pack-elasticsearch@9947f1176e
This commit is contained in:
Colin Goodheart-Smithe 2017-03-24 10:11:05 +00:00 committed by GitHub
parent cc5c34e037
commit ea67089cef
4 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugin/src/main/java/org/elasticsearch/xpack/ml/job/config/Job.java
View File

@ -122,7 +122,7 @@ public class Job extends AbstractDiffable<Job> implements Writeable, ToXContent
private final String jobId;
private final String description;
// NORELEASE: Use Jodatime instead
// TODO: Use java.time for the Dates here: x-pack-elasticsearch#829
private final Date createTime;
private final Date finishedTime;
private final Date lastDataTime;

2
plugin/src/main/java/org/elasticsearch/xpack/ml/job/process/autodetect/state/DataCounts.java
View File

@ -153,7 +153,7 @@ public class DataCounts extends ToXContentToBytes implements Writeable {
private long emptyBucketCount;
private long sparseBucketCount;
private long bucketCount;
// NORELEASE: Use Jodatime instead
// TODO: Use java.time for the Dates here: x-pack-elasticsearch#829
private Date earliestRecordTimeStamp;
private Date latestRecordTimeStamp;
private Date lastDataTimeStamp;

1
plugin/src/main/java/org/elasticsearch/xpack/ml/job/process/autodetect/state/ModelSizeStats.java
View File

@ -266,7 +266,6 @@ public class ModelSizeStats extends ToXContentToBytes implements Writeable {
&& Objects.equals(this.jobId, that.jobId);
}
// NORELEASE This will not be needed once we are able to parse ModelSizeStats all at once.
public static class Builder {
private final String jobId;

7
plugin/src/main/java/org/elasticsearch/xpack/ml/utils/ExceptionsHelper.java
View File

@ -6,15 +6,12 @@
package org.elasticsearch.xpack.ml.utils;
import org.elasticsearch.ElasticsearchException;
import org.elasticsearch.ElasticsearchParseException;
import org.elasticsearch.ElasticsearchStatusException;
import org.elasticsearch.ResourceAlreadyExistsException;
import org.elasticsearch.ResourceNotFoundException;
import org.elasticsearch.common.ParseField;
import org.elasticsearch.rest.RestStatus;
import org.elasticsearch.xpack.ml.job.messages.Messages;
// NORELEASE: add cause exceptions!
public class ExceptionsHelper {
public static ResourceNotFoundException missingJobException(String jobId) {
@ -41,10 +38,6 @@ public class ExceptionsHelper {
return new ElasticsearchStatusException(msg, RestStatus.CONFLICT);
}
public static ElasticsearchParseException parseException(ParseField parseField, Throwable cause) {
throw new ElasticsearchParseException("Failed to parse [" + parseField.getPreferredName() + "]", cause);
}
/**
* A more REST-friendly Object.requireNonNull()
*/