honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-16 18:04:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add plugin installer test for plugin jar contents (#58287)

Browse Source 
The plugin installer currently checks the fake plugins installed contain
a single jar file. This commit adds another test for a plugin which
contains multiple jar files, ensuring all jars exist in the installed
plugin.
This commit is contained in:
Ryan Ernst 2020-06-24 09:49:09 -07:00 committed by Ryan Ernst
parent 9e4c5d1dde
commit eb16ad4574
No known key found for this signature in database
GPG Key ID: 5F7EA39E15F54DCE
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
distribution/tools/plugin-cli/src/test/java/org/elasticsearch/plugins/InstallPluginCommandTests.java
View File

@ -304,12 +304,12 @@ public class InstallPluginCommandTests extends ESTestCase {
}
void assertPlugin(String name, Path original, Environment env) throws IOException {
assertPluginInternal(name, env.pluginsFile());
assertPluginInternal(name, env.pluginsFile(), original);
assertConfigAndBin(name, original, env);
assertInstallCleaned(env);
}
void assertPluginInternal(String name, Path pluginsFile) throws IOException {
void assertPluginInternal(String name, Path pluginsFile, Path originalPlugin) throws IOException {
Path got = pluginsFile.resolve(name);
assertTrue("dir " + name + " exists", Files.exists(got));
@ -328,7 +328,12 @@ public class InstallPluginCommandTests extends ESTestCase {
)
);
}
assertTrue("jar was copied", Files.exists(got.resolve("plugin.jar")));
try (Stream<Path> files = Files.list(originalPlugin).filter(p -> p.getFileName().toString().endsWith(".jar"))) {
files.forEach(file -> {
Path expectedJar = got.resolve(originalPlugin.relativize(file).toString());
assertTrue("jar [" + file.getFileName() + "] was copied", Files.exists(expectedJar));
});
}
assertFalse("bin was not copied", Files.exists(got.resolve("bin")));
assertFalse("config was not copied", Files.exists(got.resolve("config")));
}
@ -1497,4 +1502,14 @@ public class InstallPluginCommandTests extends ESTestCase {
final IllegalStateException e = expectThrows(IllegalStateException.class, () -> installPlugin(pluginZip, env.v1()));
assertThat(e, hasToString(containsString("plugins can not have native controllers")));
}
public void testMultipleJars() throws Exception {
Tuple<Path, Environment> env = createEnv(fs, temp);
Path pluginDir = createPluginDir(temp);
writeJar(pluginDir.resolve("dep1.jar"), "Dep1");
writeJar(pluginDir.resolve("dep2.jar"), "Dep2");
String pluginZip = createPluginUrl("fake-with-deps", pluginDir);
installPlugin(pluginZip, env.v1());
assertPlugin("fake-with-deps", pluginDir, env.v2());
}
}