honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ML] Audit all errors during job deletion (#37933) 

This commit moves the auditing of job deletion related errors
to the final listener in the job delete action. This ensures
any error that occurs during job deletion is audited.
This commit is contained in:
Dimitris Athanasiou 2019-01-29 10:23:50 +02:00 committed by GitHub
parent 891320f5ac
commit ebe9c95230
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportDeleteJobAction.java
View File

@ -181,7 +181,10 @@ public class TransportDeleteJobAction extends TransportMasterNodeAction<DeleteJo
// The listener that will be executed at the end of the chain will notify all listeners
ActionListener<AcknowledgedResponse> finalListener = ActionListener.wrap(
ack -> notifyListeners(request.getJobId(), ack, null),
e -> notifyListeners(request.getJobId(), null, e)
e -> {
notifyListeners(request.getJobId(), null, e);
auditor.error(request.getJobId(), Messages.getMessage(Messages.JOB_AUDIT_DELETING_FAILED, e.getMessage()));
}
);
ActionListener<Boolean> markAsDeletingListener = ActionListener.wrap(
@ -192,10 +195,7 @@ public class TransportDeleteJobAction extends TransportMasterNodeAction<DeleteJo
normalDeleteJob(parentTaskClient, request, finalListener);
}
},
e -> {
auditor.error(request.getJobId(), Messages.getMessage(Messages.JOB_AUDIT_DELETING_FAILED, e.getMessage()));
finalListener.onFailure(e);
});
finalListener::onFailure);
ActionListener<Boolean> jobExistsListener = ActionListener.wrap(
response -> {