Marvel integ test should stop and start exporters between tests. The ongoing activity messes with ESIntegTest level clean ups

Original commit: elastic/x-pack-elasticsearch@474ed7080a
This commit is contained in:
Boaz Leskes 2016-03-30 08:54:43 +02:00
parent e0fcbcbb51
commit ec34163b01
3 changed files with 26 additions and 1 deletions

View File

@ -19,6 +19,18 @@ import static org.hamcrest.Matchers.equalTo;
@ClusterScope(scope = TEST, transportClientRatio = 0, numClientNodes = 0, numDataNodes = 0) @ClusterScope(scope = TEST, transportClientRatio = 0, numClientNodes = 0, numDataNodes = 0)
public class MarvelPluginTests extends MarvelIntegTestCase { public class MarvelPluginTests extends MarvelIntegTestCase {
@Override
protected void startCollection() {
// do nothing as marvel is sometime unbound
}
@Override
protected void stopCollection() {
// do nothing as marvel is sometime unbound
}
@Override @Override
protected Settings nodeSettings(int nodeOrdinal) { protected Settings nodeSettings(int nodeOrdinal) {
return Settings.builder() return Settings.builder()

View File

@ -84,7 +84,6 @@ public class HttpExporterTests extends MarvelIntegTestCase {
@After @After
public void cleanup() throws Exception { public void cleanup() throws Exception {
stopCollection();
webServer.shutdown(); webServer.shutdown();
} }

View File

@ -39,6 +39,8 @@ import org.elasticsearch.xpack.XPackClient;
import org.elasticsearch.xpack.XPackPlugin; import org.elasticsearch.xpack.XPackPlugin;
import org.hamcrest.Matcher; import org.hamcrest.Matcher;
import org.jboss.netty.util.internal.SystemPropertyUtil; import org.jboss.netty.util.internal.SystemPropertyUtil;
import org.junit.After;
import org.junit.Before;
import java.io.BufferedWriter; import java.io.BufferedWriter;
import java.io.IOException; import java.io.IOException;
@ -166,6 +168,18 @@ public abstract class MarvelIntegTestCase extends ESIntegTestCase {
return templates; return templates;
} }
@Before
public void setUp() throws Exception {
super.setUp();
startCollection();
}
@After
public void tearDown() throws Exception {
stopCollection();
super.tearDown();
}
/** /**
* Override and return {@code false} to force running without Security. * Override and return {@code false} to force running without Security.
*/ */