Merge remote-tracking branch 'origin/master'

This commit is contained in:
David Pilato 2017-02-03 16:11:16 +01:00
commit ed324d373a
1 changed files with 16 additions and 3 deletions

View File

@ -120,10 +120,23 @@ public class RemoteScrollableHitSource extends ScrollableHitSource {
} }
@Override @Override
public void onFailure(Exception t) { public void onFailure(Exception e) {
logger.warn((Supplier<?>) () -> new ParameterizedMessage("Failed to clear scroll [{}]", scrollId), t); logFailure(e);
onCompletion.run(); onCompletion.run();
} }
private void logFailure(Exception e) {
if (e instanceof ResponseException) {
ResponseException re = (ResponseException) e;
if (remoteVersion.before(Version.V_2_0_0) && re.getResponse().getStatusLine().getStatusCode() == 404) {
logger.debug((Supplier<?>) () -> new ParameterizedMessage(
"Failed to clear scroll [{}] from pre-2.0 Elasticsearch. This is normal if the request terminated "
+ "normally as the scroll has already been cleared automatically.", scrollId), e);
return;
}
}
logger.warn((Supplier<?>) () -> new ParameterizedMessage("Failed to clear scroll [{}]", scrollId), e);
}
}); });
} }
@ -134,7 +147,7 @@ public class RemoteScrollableHitSource extends ScrollableHitSource {
threadPool.generic().submit(() -> { threadPool.generic().submit(() -> {
try { try {
client.close(); client.close();
logger.info("Shut down remote connection"); logger.debug("Shut down remote connection");
} catch (IOException e) { } catch (IOException e) {
logger.error("Failed to shutdown the remote connection", e); logger.error("Failed to shutdown the remote connection", e);
} }