honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

review comments

This commit is contained in:
Colin Goodheart-Smithe 2016-03-22 15:34:47 +00:00
parent b8a96d9a65
commit ee7e84acc3
1 changed files with 27 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
docs/reference/migration/migrate_5_0/java.asciidoc
View File

@ -229,16 +229,16 @@ The `field` setter has been deleted. Instead the field name needs to be specifie
==== SearchSourceBuilder ==== SearchSourceBuilder
All methods which take an `XContentBuilder`, `BytesReference` `Map<String, Object>` or `bytes[]` have been removed in favor of providing the All methods which take an `XContentBuilder`, `BytesReference` `Map<String, Object>` or `bytes[]` have been removed in favor of providing the
relevant builder object for that feature. This means that all search requests can now be validated at call time which results in much clearer relevant builder object for that feature (e.g. HighlightBuilder, AggregationBuilder, SuggesterBuilder) . This means that all search requests
errors. can now be validated at call time which results in much clearer errors.
The `defaultResourceWindowSize(int)` method has been removed. The window size should be set explicitly on all RescoreBuilder objects. The `defaultResourceWindowSize(int)` method has been removed. The window size should be set explicitly on all RescoreBuilder objects.
==== SearchRequestBuilder ==== SearchRequestBuilder
All methods which take an `XContentBuilder`, `BytesReference` `Map<String, Object>` or `bytes[]` have been removed in favor of providing the All methods which take an `XContentBuilder`, `BytesReference` `Map<String, Object>` or `bytes[]` have been removed in favor of providing the
relevant builder object for that feature. This means that all search requests can now be validated at call time which results in much clearer relevant builder object for that feature (e.g. HighlightBuilder, AggregationBuilder, SuggesterBuilder) . This means that all search requests
errors. can now be validated at call time which results in much clearer errors.
All highlighter methods have been removed in favor of a single `highlighter(HighlightBuilder)` method. All highlighter methods have been removed in favor of a single `highlighter(HighlightBuilder)` method.
@ -252,13 +252,31 @@ The `setTemplateSource(String)` and `setTemplateSource(BytesReference)` methods
All template methods have been removed in favor of a single `template(Template)` method. All template methods have been removed in favor of a single `template(Template)` method.
All source methods have been removed in favor of a single `source(SearchSourceBuilder)` method. This means that all search requests can now be validated at call time which results in much clearer All source methods have been removed in favor of a single `source(SearchSourceBuilder)` method. This means that all search requests can now be validated
errors. at call time which results in much clearer errors.
All extraSource methods have been removed. All extraSource methods have been removed.
==== AggregationBuilder ==== AggregationBuilder
All method which take an `XContentBuilder`, `BytesReference` `Map<String, Object>` or `bytes[]` have been removed in favor of providing the All methods which take an `XContentBuilder`, `BytesReference` `Map<String, Object>` or `bytes[]` have been removed in favor of providing the
relevant builder object for that feature. This means that all requests can now be validated at call time which results in much clearer relevant builder object (i.e. `subAggregation(AggregationBuilder)` or `subAggregation(PipelineAggregationBuilder)`). This means that all
errors. requests can now be validated at call time which results in much clearer errors.
==== ValidateQueryRequest
`source(QuerySourceBuilder)`, `source(Map)`, `source(XContentBuilder)`, `source(String)`, `source(byte[])`, `source(byte[], int, int)`,
`source(BytesReference)` and `source()` have been removed in favor of using `query(QueryBuilder<?>)` and `query()`
==== ValidateQueryRequestBuilder
`setSource()` methods have been removed in favor of using `setQuery(QueryBuilder<?>)`
==== ExplainRequest
`source(QuerySourceBuilder)`, `source(Map)`, `source(BytesReference)` and `source()` have been removed in favor of using
`query(QueryBuilder<?>)` and `query()`
==== ExplainRequestBuilder
The `setQuery(BytesReference)` method have been removed in favor of using `setQuery(QueryBuilder<?>)`