diff --git a/core/src/main/java/org/elasticsearch/bootstrap/JavaVersion.java b/core/src/main/java/org/elasticsearch/bootstrap/JavaVersion.java index bf8e9961113..c37f37318fa 100644 --- a/core/src/main/java/org/elasticsearch/bootstrap/JavaVersion.java +++ b/core/src/main/java/org/elasticsearch/bootstrap/JavaVersion.java @@ -19,28 +19,26 @@ package org.elasticsearch.bootstrap; -import org.elasticsearch.common.Strings; - import java.util.ArrayList; import java.util.Collections; import java.util.List; +import java.util.Objects; +import java.util.stream.Collectors; class JavaVersion implements Comparable { private final List version; public List getVersion() { - return Collections.unmodifiableList(version); + return version; } private JavaVersion(List version) { - this.version = version; + this.version = Collections.unmodifiableList(version); } public static JavaVersion parse(String value) { - if (value == null) { - throw new NullPointerException("value"); - } - if ("".equals(value)) { + Objects.requireNonNull(value); + if (!isValid(value)) { throw new IllegalArgumentException("value"); } @@ -79,6 +77,6 @@ class JavaVersion implements Comparable { @Override public String toString() { - return Strings.collectionToDelimitedString(version, "."); + return version.stream().map(v -> Integer.toString(v)).collect(Collectors.joining(".")); } } diff --git a/core/src/test/java/org/elasticsearch/bootstrap/JavaVersionTests.java b/core/src/test/java/org/elasticsearch/bootstrap/JavaVersionTests.java index 21bfa05c1d4..d2ef349625e 100644 --- a/core/src/test/java/org/elasticsearch/bootstrap/JavaVersionTests.java +++ b/core/src/test/java/org/elasticsearch/bootstrap/JavaVersionTests.java @@ -36,8 +36,10 @@ public class JavaVersionTests extends ESTestCase { } public void testToString() { - JavaVersion javaVersion = JavaVersion.parse("1.7.0"); - assertThat("1.7.0", is(javaVersion.toString())); + JavaVersion javaVersion170 = JavaVersion.parse("1.7.0"); + assertThat(javaVersion170.toString(), is("1.7.0")); + JavaVersion javaVersion9 = JavaVersion.parse("9"); + assertThat(javaVersion9.toString(), is("9")); } public void testCompare() {